Repository navigation
Added extraCACerts config - #1214
Conversation
|
nicktrn
left a comment
There was a problem hiding this comment.
Thanks for this @gautamsi!
Good call with resolveConfig(). I think it will be a lot cleaner doing everything in there, that is:
- Add the raw
extraCACertspath toadditionalFiles - Tranform it so
resolvedConfig.extraCACertsnow points at the deployed destination path ->/app/...
Re the last point: We could even just strip .. and keep the path relative to /app if NODE_EXTRA_CA_CERTS works fine with relative paths. /app is the work dir in the resulting image so that should be fine.
|
I will update this soon |
|
Thanks for the changes! Will get this merged and tested. Should be in the next release. |
|
verified beta-49 works with this feature :) |
|
I did test this locally briefly and relative paths work as well 👍 |
Closes #1210
✅ Checklist
Testing
extraCACertsconfig./ca.crtChangelog
Added config option
extraCACertstoProjectConfigtype. This copies the ca file along withadditionalFilesand setsNODE_EXTRA_CA_CERTSenvironment variable in built image as well as running the task.Screenshots
[Screenshots]
💯