Oauth2 integration #2953
Merged
Oauth2 integration #2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDimonaco
added
enhancement
CDimonaco
force-pushed
the
oauth2_integration
branch
from
e7842e2
to
de7732d
Compare
arbulu89
approved these changes
Sep 9, 2024
arbulu89
reviewed
Sep 9, 2024
There was a problem hiding this comment.
Hey @CDimonaco ,
I was testing the PR and i was having an error.
Adding the single line in my comment fixes it, but I don't know if something else could be affecting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Oauth2 SSO method.
All the runtime parameters, needed claims and scopes, will be later documented.
Locally we can use our keycloak instance with the same client who supports also plain oauth2, the local scopes are tailored to work with our local keycloak.
Tested also with Auth0.
This PR also adds supports for multiple forms of SSO, allowing for multiple integrations.
The SSO username retrieving is refactored.
To test it locally, in the
dev.local.exsaddHow was this tested?
Automatic and manual testing.