Add OAUTH2 usage #105
Merged
Add OAUTH2 usage #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
force-pushed
the
add-oauth2-usage
branch
from
860dda2
to
120c349
Compare
EMaksy
reviewed
Sep 12, 2024
| authorizeUrl: "" | ||
| tokenUrl: "" | ||
| userUrl: "" | ||
| scopes: "profile email" |
There was a problem hiding this comment.
Yes. If I don't set the default value (the same we have in the runtime), as helm will always populate this value (even with an empty string), this would be the passed value, and sending an empty string doesn't look appropriate
There was a problem hiding this comment.
Ah okay i wondered because we had here an empty string trento-project/ansible@3bd8cf2#diff-018072a0a2fd65ea8a5deb35db17eb24ec9297cc2fffd3ec7979e6cf402577e7R37.
Thanks for clarification!
There was a problem hiding this comment.
I will add the default actually in the ansible code.
thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OAUTH2 support.
Based on: trento-project/web#2953
Usage example (keycloak):
Attention: the configured urls must be reachable by the k3s containers. Don't use
localhost