Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document systemd gatherer #89

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Document systemd gatherer #89

merged 1 commit into from
Nov 18, 2022

Conversation

arbulu89
Copy link
Contributor

Related to: trento-project/agent#139

I think we should remove this 1st name header (duplicated content) and the pseudo function code snippet.
It looks totally redundant, and I personally don't find it useful

@arbulu89 arbulu89 added the documentation Improvements or additions to documentation label Nov 17, 2022
@coveralls
Copy link
Collaborator

coveralls commented Nov 17, 2022

Coverage Status

coverage: 94.737%. remained the same
when pulling f46653a on document-systemd-gatherer
into 639fd9d on main.

Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree. I was having second thought as well.
Gonna adjust my PR accordingly.

@arbulu89 arbulu89 merged commit 1a2dc5a into main Nov 18, 2022
@arbulu89 arbulu89 deleted the document-systemd-gatherer branch November 18, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

Successfully merging this pull request may close these issues.

3 participants