Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port systemd gatherer #139

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Port systemd gatherer #139

merged 2 commits into from
Nov 17, 2022

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Nov 16, 2022

Port systemd gatherer to use the new FactValue object. The used argument is the name of the daemon to get the state.
It returns an active/inactive string. If the deamon is disabled or does not even exist, inactive is returned.
We could actually return more things as map if needed. All of this
Ref.

facts:
  - name: sbd_state
    gatherer: systemd
    argument: sbd

PD:
I have renamed some constants from other gatherers to use more meaningful names.

@arbulu89 arbulu89 marked this pull request as ready for review November 16, 2022 15:05
Copy link
Contributor

@rtorrero rtorrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and it actually reminded me that we had agreed on changing the FactKey naming for something more understandable and that I need to change the testing package name with the _test in my last PRs too 😅

@arbulu89
Copy link
Contributor Author

LGTM and it actually reminded me that we had agreed on changing the FactKey naming for something more understandable and that I need to change the testing package name with the _test in my last PRs too sweat_smile

Aaa yes!
We should start looking on that in new pieces of code.
I forgot in the review...

@arbulu89 arbulu89 added the enhancement New feature or request label Nov 17, 2022
@arbulu89 arbulu89 merged commit 083d33a into main Nov 17, 2022
@arbulu89 arbulu89 deleted the port-systemd-gatherer branch November 17, 2022 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants