Improve expression hierarchy #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem ------- Currently we use `$.expression` everywhere even though it often requires much narrower set of expressions. Solution -------- Now that we've gained some memory budget, this adds `_simple_expression`, mirroring the EBNF, and adjusts `infix_expression` etc to use narrower choice of expression tokens. With this change, the smoke test for Scala 2 library jumps to 95%.
eed3si9n
commented
Jan 9, 2023
Comment on lines
+5
to
+7
| SCALA_SCALA_LIBRARY_EXPECTED=95 | ||
| SCALA_SCALA_COMPILER_EXPECTED=66 | ||
| DOTTY_COMPILER_EXPECTED=56 |
Collaborator
There was a problem hiding this comment.
Awesome to see this keep going up.
Merged
ckipp01
approved these changes
Jan 9, 2023
Comment on lines
+5
to
+7
| SCALA_SCALA_LIBRARY_EXPECTED=95 | ||
| SCALA_SCALA_COMPILER_EXPECTED=66 | ||
| DOTTY_COMPILER_EXPECTED=56 |
Collaborator
There was a problem hiding this comment.
Awesome to see this keep going up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #106
Problem
Currently we use
$.expressioneverywhere even though it oftenrequires much narrower set of expressions.
Solution
Now that we've gained some memory budget, this adds
_simple_expression, mirroring the EBNF, and adjustsinfix_expressionetc to use narrower choice of expression tokens.With this change, the smoke test for Scala 2 library jumps to 95%.