Optimize codegen memory usage, part 2 #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem ------- Memory usage already regressed a bit to 15GB. ``` $ /usr/bin/time -f "%P %M" node_modules/.bin/tree-sitter generate 99% 15625000 ``` Running ``` $ node_modules/.bin/tree-sitter generate --report-states-for-rule compilation_unit given_definition 4434 type_definition 2538 function_definition 2322 ``` show that `given_definition` might be the culprit. Solution -------- Apply the same `class_constructor` trick to `given_definition`, enum, `function_definition`, `function_declaration`, bringing down the memory usage down to one (1) GB. ``` $ /usr/bin/time -f "%P %M" node_modules/.bin/tree-sitter generate 99% 1078896 ```
This was referenced Jan 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #97
Problem
Memory usage already regressed a bit to 15GB.
Running
show that
given_definitionmight be the culprit.Solution
Apply the same
class_constructortrick togiven_definition, enum,function_definition,function_declaration, bringing down the memory usage down to one (1) GB.