Save submissions in a proper order #4724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.59%@@ master #4724 diff @@
==========================================
Files 345 341 -4
Lines 18774 18801 +27
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 15861 15903 +42
+ Misses 2913 2898 -15
Partials 0 0
|
|
lgtm |
1 similar comment
|
lgtm |
|
Happy to see this addressed! GTM. As an orthogonal cleanup, I have also filed #4731. |
|
Hm, as reported on IRC, when going from untranslated -> translated, the timeline now displays the state change on top of the text provided as a translation. With submissions that happened with code from master this is not the case and the elements are displayed in the expected order.
|
|
It's properly displayed now @ta2-1 👍 |
- fuzzy -> translated in store.update() - untranslted -> translated in submit new translation - fuzzy -> translated in accept suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #4621 issue.
Target field submission are saved after state field always.