Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Submission recording away from views #4731

Open
julen opened this issue May 13, 2016 · 0 comments
Open

Move Submission recording away from views #4731

julen opened this issue May 13, 2016 · 0 comments
Labels
Milestone

Comments

@julen
Copy link
Contributor

julen commented May 13, 2016

The translation submission view (pootle_store.views.submit) currently contains logic to record submissions and this should ideally be done in the business logic layer in models — this is already the case for other actions which record submissions, such as suggestion handling and toggling quality checks.

Having the logic in models would be more natural and would make testing easier, as it wouldn't be necessary to write test code against a view (with all the required wiring) but rather directly against the model. View code would also become simpler.

This is to some extent also related to #3895 and splitting submission types.

@julen julen added the cleanup label May 13, 2016
@phlax phlax added this to the 2.8.1 milestone May 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants