Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NETRC to the default_pass_env list #3410

Merged
merged 8 commits into from
Oct 17, 2024
Merged

Add NETRC to the default_pass_env list #3410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d23066e
Update api.py
chipot Oct 16, 2024
c27007f
Update config.rst
chipot Oct 16, 2024
37660a1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 16, 2024
4d87862
Update test_show_config.py
chipot Oct 16, 2024
261c877
Update test_show_config.py
chipot Oct 16, 2024
4b85319
Create 3410.feature.rst
chipot Oct 17, 2024
bc86d29
Merge branch 'main' into main
gaborbernat Oct 17, 2024
ed1a098
Update 3410.feature.rst (fix mistake with backticks)
chipot Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/changelog/3410.feature.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add ``NETRC`` to the list of environment variables always passed through.
5 changes: 5 additions & 0 deletions docs/config.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,6 +530,11 @@ Base options
- ✅
- ✅
- ✅
* - NETRC
- ✅
- ✅
- ✅



More environment variable-related information
Expand Down
1 change: 1 addition & 0 deletions src/tox/tox_env/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ def _default_pass_env(self) -> list[str]: # noqa: PLR6301
"HOME", # needed for `os.path.expanduser()` on non-Windows systems
"FORCE_COLOR", # force color output
"NO_COLOR", # disable color output
"NETRC", # used by pip and netrc modules
]
if sys.stdout.isatty(): # if we're on a interactive shell pass on the TERM
env.append("TERM")
Expand Down
2 changes: 1 addition & 1 deletion tests/session/cmd/test_show_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def test_pass_env_config_default(tox_project: ToxProjectCreator, stdout_is_atty:
+ ["CPPFLAGS", "CURL_CA_BUNDLE", "CXX", "FORCE_COLOR", "HOME", "LANG"]
+ ["LANGUAGE", "LDFLAGS", "LD_LIBRARY_PATH"]
+ (["MSYSTEM"] if is_win else [])
+ ["NO_COLOR"]
+ ["NETRC", "NO_COLOR"]
+ (["NUMBER_OF_PROCESSORS", "PATHEXT"] if is_win else [])
+ ["PIP_*", "PKG_CONFIG", "PKG_CONFIG_PATH", "PKG_CONFIG_SYSROOT_DIR"]
+ (["PROCESSOR_ARCHITECTURE"] if is_win else [])
Expand Down
Loading