Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NETRC to the default_pass_env list #3410

Merged
merged 8 commits into from
Oct 17, 2024
Merged

Conversation

chipot
Copy link
Contributor

@chipot chipot commented Oct 16, 2024

Add NETRC to the list of default_pass_env.
This is used by pip when downloading package from an index needing authentication.

My usecase is a CI process needing to obtain authentication tokens and pass them to pip for it to be able to use the index. Installing the credentials in ~/.netrc would work but isn't always possible when using temporary tokens, or running CI jobs in parallel on the same host. The other supported way is to write a temporary netrc file, and point pip to it using NETRC environment variable. After the CI run is done, this netrc can be removed.

  • [] ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

Add NETRC to the list of default_pass_env. This is used by pip when downloading package from an index needing authentication.
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failing.

@gaborbernat gaborbernat marked this pull request as draft October 16, 2024 08:06
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog please.

@gaborbernat gaborbernat marked this pull request as ready for review October 17, 2024 03:39
Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit c01a023 into tox-dev:main Oct 17, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants