Skip to content

MAINTAINERS: Remove some entries due to some reliability requirements. #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

M1andy
Copy link

@M1andy M1andy commented Oct 24, 2024

Follow 6e90b67.
Remove some entries due to some reliability requirements. They can come
back in the future if sufficient documentation is provided.

@KernelPRBot
Copy link

Hi @M1andy!

Thanks for your contribution to the Linux kernel!

Linux kernel development happens on mailing lists, rather than on GitHub - this GitHub repository is a read-only mirror that isn't used for accepting contributions. So that your change can become part of Linux, please email it to us as a patch.

Sending patches isn't quite as simple as sending a pull request, but fortunately it is a well documented process.

Here's what to do:

  • Format your contribution according to kernel requirements
  • Decide who to send your contribution to
  • Set up your system to send your contribution as an email
  • Send your contribution and wait for feedback

How do I format my contribution?

The Linux kernel community is notoriously picky about how contributions are formatted and sent. Fortunately, they have documented their expectations.

Firstly, all contributions need to be formatted as patches. A patch is a plain text document showing the change you want to make to the code, and documenting why it is a good idea.

You can create patches with git format-patch.

Secondly, patches need 'commit messages', which is the human-friendly documentation explaining what the change is and why it's necessary.

Thirdly, changes have some technical requirements. There is a Linux kernel coding style, and there are licensing requirements you need to comply with.

Both of these are documented in the Submitting Patches documentation that is part of the kernel.

Note that you will almost certainly have to modify your existing git commits to satisfy these requirements. Don't worry: there are many guides on the internet for doing this.

Where do I send my contribution?

The Linux kernel is composed of a number of subsystems. These subsystems are maintained by different people, and have different mailing lists where they discuss proposed changes.

If you don't already know what subsystem your change belongs to, the get_maintainer.pl script in the kernel source can help you.

get_maintainer.pl will take the patch or patches you created in the previous step, and tell you who is responsible for them, and what mailing lists are used. You can also take a look at the MAINTAINERS file by hand.

Make sure that your list of recipients includes a mailing list. If you can't find a more specific mailing list, then LKML - the Linux Kernel Mailing List - is the place to send your patches.

It's not usually necessary to subscribe to the mailing list before you send the patches, but if you're interested in kernel development, subscribing to a subsystem mailing list is a good idea. (At this point, you probably don't need to subscribe to LKML - it is a very high traffic list with about a thousand messages per day, which is often not useful for beginners.)

How do I send my contribution?

Use git send-email, which will ensure that your patches are formatted in the standard manner. In order to use git send-email, you'll need to configure git to use your SMTP email server.

For more information about using git send-email, look at the Git documentation or type git help send-email. There are a number of useful guides and tutorials about git send-email that can be found on the internet.

How do I get help if I'm stuck?

Firstly, don't get discouraged! There are an enormous number of resources on the internet, and many kernel developers who would like to see you succeed.

Many issues - especially about how to use certain tools - can be resolved by using your favourite internet search engine.

If you can't find an answer, there are a few places you can turn:

If you get really, really stuck, you could try the owners of this bot, @daxtens and @ajdlinux. Please be aware that we do have full-time jobs, so we are almost certainly the slowest way to get answers!

I sent my patch - now what?

You wait.

You can check that your email has been received by checking the mailing list archives for the mailing list you sent your patch to. Messages may not be received instantly, so be patient. Kernel developers are generally very busy people, so it may take a few weeks before your patch is looked at.

Then, you keep waiting. Three things may happen:

  • You might get a response to your email. Often these will be comments, which may require you to make changes to your patch, or explain why your way is the best way. You should respond to these comments, and you may need to submit another revision of your patch to address the issues raised.
  • Your patch might be merged into the subsystem tree. Code that becomes part of Linux isn't merged into the main repository straight away - it first goes into the subsystem tree, which is managed by the subsystem maintainer. It is then batched up with a number of other changes sent to Linus for inclusion. (This process is described in some detail in the kernel development process guide).
  • Your patch might be ignored completely. This happens sometimes - don't take it personally. Here's what to do:
    • Wait a bit more - patches often take several weeks to get a response; more if they were sent at a busy time.
    • Kernel developers often silently ignore patches that break the rules. Check for obvious violations of the Submitting Patches guidelines, the style guidelines, and any other documentation you can find about your subsystem. Check that you're sending your patch to the right place.
    • Try again later. When you resend it, don't add angry commentary, as that will get your patch ignored. It might also get you silently blacklisted.

Further information

Happy hacking!

This message was posted by a bot - if you have any questions or suggestions, please talk to my owners, @ajdlinux and @daxtens, or raise an issue at https://github.com/ajdlinux/KernelPRBot.

@Butterblock233
Copy link

image

Copy link

@FrostleafChan FrostleafChan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

闹麻了

@ThatsEmbarrassing
Copy link

LGTM!

@copi143
Copy link

copi143 commented Oct 24, 2024

Please don't use sarcasm or discuss unrelated topics; it's not funny. Most people likely hope the community can return to a politically neutral state.


请不要反串或讨论无关内容,这并不好笑。大多数人应该还是希望社区能够恢复到与政治无关的状态的。

@Butterblock233
Copy link

事已至此,先祝各位节日快乐吧

@M1andy
Copy link
Author

M1andy commented Oct 24, 2024

Please don't use sarcasm or discuss unrelated topics; it's not funny. Most people likely hope the community can return to a politically neutral state.

请不要反串或讨论无关内容,这并不好笑。大多数人应该还是希望社区能够恢复到与政治无关的状态的。

Nearly everybody doesn't want to deal with politics in a free or open-source project, but there is no accelerator or brake under my feet. Before the linux foundation or linus revert the commit or give a detailed illstration, these objections remain.


没人想在一个开源项目里讨论政治,但是现在控制整个社区言论走向的不是我。在linux基金会和linus给出解释或者撤回那个提交之前,反对意见必然存在。

@cxw620
Copy link

cxw620 commented Oct 24, 2024

Please don't use sarcasm or discuss unrelated topics; it's not funny. Most people likely hope the community can return to a politically neutral state.

请不要反串或讨论无关内容,这并不好笑。大多数人应该还是希望社区能够恢复到与政治无关的状态的。

This is simply an anonymous developer attempting to express his dissent.

Moreover, who exactly is imposing political agendas in open-source projects? Linus itself!

@Elvisass
Copy link

Please don't use sarcasm or discuss unrelated topics; it's not funny. Most people likely hope the community can return to a politically neutral state.

请不要反串或讨论无关内容,这并不好笑。大多数人应该还是希望社区能够恢复到与政治无关的状态的。

If you don't speak up, Linus will keep pushing his politics.

形势由不得你,你不讨论,Linus就会继续引入政治。

@real-LiHua
Copy link
Contributor

LGTM

@humb1t
Copy link

humb1t commented Oct 24, 2024

LGTM

@AlexHudnev
Copy link

@torvalds Linus Benedict Torvalds you are a nationalist

@duzhuoshanwai
Copy link

Please don't use sarcasm or discuss unrelated topics; it's not funny. Most people likely hope the community can return to a politically neutral state.
请不要反串或讨论无关内容,这并不好笑。大多数人应该还是希望社区能够恢复到与政治无关的状态的。

Nearly everybody doesn't want to deal with politics in a free or open-source project, but there is no accelerator or brake under my feet. Before the linux foundation or linus revert the commit or give a detailed illstration, these objections remain.

没人想在一个开源项目里讨论政治,但是现在控制整个社区言论走向的不是我。在linux基金会和linus给出解释或者撤回那个提交之前,反对意见必然存在。

林纳斯现在算不算房间里的大象

@Licshee
Copy link

Licshee commented Oct 25, 2024

Linus just introduced the politics shit into the community by himself, and somebody want everyone else just pretend it didn't happen now!?

@YJ-305-A2
Copy link

#993 (comment)
我超,vv

@liangguifeng
Copy link

LGTM

@M1andy M1andy closed this by deleting the head repository Dec 19, 2024
torvalds pushed a commit that referenced this pull request Jun 23, 2025
Add a macro CRYPTO_MD5_STATESIZE for the Crypto API export state
size of md5 and use that in dm-crypt instead of relying on the
size of struct md5_state (the latter is currently undergoing a
transition and may shrink).

This commit fixes a crash on 32-bit machines:
Oops: Oops: 0000 [#1] SMP
CPU: 1 UID: 0 PID: 12 Comm: kworker/u16:0 Not tainted 6.16.0-rc2+ #993 PREEMPT(full)
Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 11/12/2020
Workqueue: kcryptd-254:0-1 kcryptd_crypt [dm_crypt]
EIP: __crypto_shash_export+0xf/0x90
Code: 4a c1 c7 40 20 a0 b4 4a c1 81 cf 0e 00 04 08 89 78 50 e9 2b ff ff ff 8d 74 26 00 55 89 e5 57 56 53 89 c3 89 d6 8b 00 8b 40 14 <8b> 50 fc f6 40 13 01 74 04 4a 2b 50 14 85 c9 74 10 89 f2 89 d8 ff
EAX: 303a3435 EBX: c3007c90 ECX: 00000000 EDX: c3007c38
ESI: c3007c38 EDI: c3007c90 EBP: c3007bfc ESP: c3007bf0
DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068 EFLAGS: 00010216
CR0: 80050033 CR2: 303a3431 CR3: 04fbe000 CR4: 00350e90
Call Trace:
 crypto_shash_export+0x65/0xc0
 crypt_iv_lmk_one+0x106/0x1a0 [dm_crypt]

Fixes: efd62c8 ("crypto: md5-generic - Use API partial block handling")
Reported-by: Milan Broz <gmazyland@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Tested-by: Milan Broz <gmazyland@gmail.com>
Closes: https://lore.kernel.org/linux-crypto/f1625ddc-e82e-4b77-80c2-dc8e45b54848@gmail.com/T/
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.