refactor: [#199] use black-box CLI execution in E2E provision tests #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor e2e_provision_and_destroy_tests to execute CLI commands via ProcessRunner instead of directly calling application layer command handlers - Move ProcessRunner from tests/support/ to src/testing/black_box/ for sharing between src/bin/ and tests/ - Add run_provision_command method to ProcessRunner - Generate environment config at runtime with absolute SSH key paths (required because Ansible runs from build directory) - Add envs/ to .gitignore and cspell ignorePaths for generated E2E config files - Re-export ProcessRunner from tests/support/ to minimize test code changes - Update issue documentation with completed acceptance criteria
- Change function parameter from 'keep' to 'destroy' for clearer intent - Default behavior (destroy=true) now comes first in the if/else - Rename 'keep' to 'destroy_on_failure' in provision_infrastructure for consistency
Member
Author
|
ACK cc9a1a7 |
josecelano
added a commit
that referenced
this pull request
Nov 26, 2025
…tests 0e3ab51 refactor: [#200] introduce E2eTestRunner abstraction (Jose Celano) 4056432 refactor: [#200] extract configure_services to shared task (Jose Celano) 612577e refactor: [#200] extract validate_deployment to shared task (Jose Celano) 28e9253 refactor: [#200] extract destroy_infrastructure to shared task (Jose Celano) e453527 refactor: [#200] extract provision_infrastructure to shared task (Jose Celano) 265c5be refactor: [#200] extract create_environment to shared task (Jose Celano) a24faa4 refactor: [#200] extract generate_environment_config to shared task (Jose Celano) 7407c8b refactor: [#200] extract run_preflight_cleanup to shared task (Jose Celano) 1df7ff1 refactor: [#200] reorganize E2E testing modules (Jose Celano) 959b4f5 refactor: [#200] extract verify_required_dependencies to shared task (Jose Celano) 0a8076f refactor: [#200] move black_box module inside e2e module (Jose Celano) 898a86d refactor: [#200] use black-box CLI execution in E2E full tests (Jose Celano) Pull request description: ## Summary Refactors `e2e_tests_full.rs` to use black-box CLI execution via `ProcessRunner`, following the same pattern established in issue #199. ## Changes - **Remove internal imports**: Eliminated `TestContext` and direct `command_handlers` imports - **Use ProcessRunner**: All CLI commands (create, provision, configure, test, destroy) now execute through `ProcessRunner` - **Extend ProcessRunner**: Added `run_configure_command` and `run_test_command` methods - **Dynamic config generation**: Generate environment config at runtime with absolute SSH key paths (required because Ansible runs from build directory) - **Consistent pattern**: Applied same black-box testing approach from issue #199 ## Testing - ✅ Pre-commit checks pass - ✅ E2E full tests pass (ran twice to verify cleanup works) ## Related - Closes #200 - Follows pattern from #199 / PR #201 ACKs for top commit: josecelano: ACK 0e3ab51 Tree-SHA512: 39eaa5b3210396db8d27cbd74cae44f818d03d46481e32573457719ce827a186f196b4e2c4194c25f40e8e0c8b63b4b44979f572f2549081be6647fb35bcfd7a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Overview
Refactor
src/bin/e2e_provision_and_destroy_tests.rsto be a "real" E2E test that executes the CLI as a black box, similar totests/e2e_create_command.rs.Closes #199
🎯 Goals
⚙️ Changes
Key Changes
Move ProcessRunner to shared location:
tests/support/process_runner.rs→src/testing/black_box/process_runner.rsrun_provision_commandmethod toProcessRunnersrc/testing/mod.rsto exposeblack_boxmoduletests/support/mod.rsto re-exportProcessRunnerfromsrc/testing/black_box(backward compatibility)Refactored Binary:
TestContextusagecommand_handlersimportsProcessRunnerto execute CLI commands:create environment --env-file <generated-config>provision e2e-provisiondestroy e2e-provisionverify_required_dependenciestestingmodule)Design Decisions
Dynamic Config Generation: Static fixture files don't work because Ansible runs from the build directory, requiring absolute paths for SSH keys. Config is generated at runtime with absolute SSH key paths.
Minimal Code Movement: Only moved
ProcessRunnertosrc/testing/black_box/since it's shared betweensrc/bin/andtests/. KeptTempWorkspaceandassertionsintests/support/(local to tests).Exit Code Verification Only: Trust CLI exit codes for now. Future enhancement: use
listcommand to verify environment state.✅ Checklist
./scripts/pre-commit.shcommand_handlersfor logic executiontest-e2e-provision.ymlpasses📁 Files Changed
src/bin/e2e_provision_and_destroy_tests.rs- Major refactor to use black-box CLI executionsrc/testing/black_box/mod.rs- New module for black-box testing utilitiessrc/testing/black_box/process_runner.rs- Moved fromtests/support/src/testing/mod.rs- Exposeblack_boxmoduletests/support/mod.rs- Re-exportProcessRunnerfor backward compatibilitydocs/issues/199-refactor-e2e-provision-and-destroy-tests.md- Updated implementation notes.gitignore- Ignore runtime-generated E2E config filecspell.json- Added project-specific terms