Skip to content

Test cp313t in CI #3494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
- name: Audit ABI3 compliance
# This may be moved into cibuildwheel itself in the future. See
# https://github.com/pypa/cibuildwheel/issues/1342
run: "pip install abi3audit && abi3audit --verbose --summary ./wheelhouse/*.whl"
run: "pip install abi3audit && abi3audit --verbose --summary ./wheelhouse/*abi3*.whl"

- uses: actions/upload-artifact@v4
with:
Expand Down
12 changes: 2 additions & 10 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ jobs:
tox_env: py312-full
- python: '3.13'
tox_env: py313-full
- python: '3.13t'
tox_env: py313t
- python: '3.14.0-alpha.1 - 3.14'
tox_env: py314-full
- python: 'pypy-3.10'
Expand Down Expand Up @@ -140,13 +142,3 @@ jobs:
# built here; the real build is defined in build.yml.
CIBW_ARCHS: native
CIBW_BUILD: cp313-manylinux*

# Alternatively, uncomment the following lines (and replace the previous CIBW_BUILD)
# to test a freethreading build of python.
#CIBW_BUILD: cp313t-manylinux*
#CIBW_ENABLE: cpython-freethreading
# I don't understand what this does but auditwheel seems to fail in this configuration.
# Since we're throwing away the wheels here, just skip it.
# TODO: When we no longer need to disable this, we can enable freethreading in
# build.yml.
#CIBW_REPAIR_WHEEL_COMMAND: ""
5 changes: 3 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ build-backend = "setuptools.build_meta"
target-version = ['py39', 'py310', 'py311', 'py312', 'py313']

[tool.cibuildwheel]
build = "cp39* cp310* cp311* cp312* cp313*"
build = "cp39* cp310* cp311* cp312* cp313* cp313t*"
enable = "cpython-freethreading"
test-command = "python -m tornado.test"

[tool.cibuildwheel.macos]
Expand All @@ -28,4 +29,4 @@ test-skip = "*-win_arm64"
# Note that because we use the stable ABI, the wheels built for
# cp39-musllinux_i686 will still be available for users of 3.13, this just
# means we won't be testing them in this configuration.
test-skip = "cp313-musllinux_i686"
test-skip = "cp313-musllinux_i686 cp313t-musllinux_i686"
4 changes: 2 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
[tox]
envlist =
# Basic configurations: Run the tests for each python version.
py39-full,py310-full,py311-full,py312-full,py313-full,pypy3-full
py39-full,py310-full,py311-full,py312-full,py313-full,py313t,pypy3-full

# Build and test the docs with sphinx.
docs
Expand Down Expand Up @@ -41,7 +41,7 @@ deps =

setenv =
# Treat the extension as mandatory in testing (but not on pypy)
{py3,py39,py310,py311,py312,py313,py314}: TORNADO_EXTENSION=1
{py3,py39,py310,py311,py312,py313,py313t,py314}: TORNADO_EXTENSION=1
# CI workers are often overloaded and can cause our tests to exceed
# the default timeout of 5s.
ASYNC_TEST_TIMEOUT=25
Expand Down