Test cp313t in CI #3494
Test cp313t in CI #3494
Conversation
lysnikolaou
commented
May 2, 2025
lysnikolaou
commented
- This adds building wheels for cp313t in CI.
- Also adds config for running the test suite under 3.13t. (this will probably fail due to the pycurl and pycares dependencies for now)
.github/workflows/test.yml
Outdated
| @@ -57,6 +57,8 @@ jobs: | |||
| tox_env: py312-full | |||
| - python: '3.13' | |||
| tox_env: py313-full | |||
| - python: '3.13t' | |||
| tox_env: py313t-full | |||
There was a problem hiding this comment.
Remove the -full to run the tests without the pycurl and pycares dependencies. (This is the one that matters; the line in tox.ini isn't used in practice)
.github/workflows/test.yml
Outdated
| @@ -139,7 +141,8 @@ jobs: | |||
| # For speed, we only build one python version and one arch. We throw away the wheels | |||
| # built here; the real build is defined in build.yml. | |||
| CIBW_ARCHS: native | |||
| CIBW_BUILD: cp313-manylinux* | |||
| CIBW_BUILD: cp313-manylinux* cp313t-manylinux* | |||
There was a problem hiding this comment.
I think I'd leave this as it was; we don't need to test freethreading builds in both tox and cibuildwheel in test.yml. What we need for publishing wheels is changes to build.yml.
There was a problem hiding this comment.
Yes, I know, I just wanted to test that they'll build okay first. I'll revert this and change build.yml.
There was a problem hiding this comment.
FYI, to test your changes to build.yml, you should be able to go to this page on your fork of the repo to use the workflow_dispatch function (it takes 20 minutes): https://github.com/lysnikolaou/tornado/actions/workflows/build.yml
I don't see the button when I look at that page, so I'm not sure whether it's because only you can see it on your fork, or if my fork of tornado is special in some way.
There was a problem hiding this comment.
I don't see it on my fork either, unfortunately. I've had the same problem with workflow_dispatch actions while working on setproctitle not too long ago.
There was a problem hiding this comment.
Fixed. Had to push a commit with a rename of the file to the master branch on my fork which repopulated the actions tab. Resetting to upstream/main is okay, the workflow still appears under my Actions tab.
