Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KNN #890

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Add KNN #890

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffc05fd
Add KNN
jkostolansky Aug 14, 2023
10874c7
Fix PR number in Changelog
jkostolansky Aug 14, 2023
1e63356
Fix test for collapse and knn
jkostolansky Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix test for collapse and knn
  • Loading branch information
@jkostolansky
jkostolansky committed Dec 8, 2023
commit 1e63356c2bb5bb64fe6e532a07f363941d7ae882
2 changes: 1 addition & 1 deletion spec/chewy/search/request_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@
expect(subject.send(name, foo: {bar: 42}).send(name, moo: {baz: 43}).render[:body])
.to include(name => {'moo' => {baz: 43}})
end
specify { expect(subject.send(name, foo: {bar: 42}).collapse(nil).render[:body]).to be_blank }
specify { expect(subject.send(name, foo: {bar: 42}).send(name, nil).render[:body]).to be_blank }
specify { expect { subject.send(name, foo: {bar: 42}) }.not_to change { subject.render } }
end
end
Expand Down