Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KNN #890

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Add KNN #890

merged 3 commits into from
Dec 12, 2023

Conversation

jkostolansky
Copy link
Contributor

Add the KNN option to the request.

PlacesIndex.knn(field: :vector, query_vector: [4, 2], k: 5, num_candidates: 50)
# => <PlacesIndex::Query {..., :body=>{:knn=>{"field"=>:vector, "query_vector"=>[4, 2], "k"=>5, "num_candidates"=>50}}}>

@tomdev
Copy link
Contributor

tomdev commented Dec 1, 2023

This sounds like a great feature addition! Is there anything we need to do before this PR can get reviewed?

@konalegi
Copy link
Contributor

konalegi commented Dec 8, 2023

Folks, sorry for the long absence, is this feature still legit?

@konalegi
Copy link
Contributor

konalegi commented Dec 8, 2023

@jkostolansky could you please rebase with master and update your branch? (ofc as long as you need this PR)

@konalegi konalegi self-assigned this Dec 8, 2023
@jkostolansky
Copy link
Contributor Author

@konalegi Sure, it's rebased. Thanks!

@konalegi konalegi merged commit a3f5026 into toptal:master Dec 12, 2023
16 checks passed
@konalegi
Copy link
Contributor

hey @jkostolansky your changes has been release https://rubygems.org/gems/chewy/versions/7.3.6

@jkostolansky
Copy link
Contributor Author

Thank you, @konalegi 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants