Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore empty blank options on fields #778

Merged
merged 77 commits into from
Apr 2, 2021
Merged

Ignore empty blank options on fields #778

merged 77 commits into from
Apr 2, 2021

Commits on Mar 25, 2021

  1. Add geo_point location field to base_spec.rb

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    c5ad207 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2021

  1. Add geo_point expect to spec

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    b58356a View commit details
    Browse the repository at this point in the history

  2. Add field ignore_blank flag with ability to skip fields with .blank… 

    …? values
    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    1e0fa94 View commit details
    Browse the repository at this point in the history

  3. Add ignore_blank to geo_point field spec in /spec/chewy/fields/base_s… 

    …pec.rb
    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    bbebecb View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into ignore-empty-blank-options-on-fields

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    bdf6d67 View commit details
    Browse the repository at this point in the history

  5. Reorganize base_spec objects and scopes section

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    ab8cca5 View commit details
    Browse the repository at this point in the history

  6. Add geo_point type without ignore_blank: true flag spec

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    f7cf5d3 View commit details
    Browse the repository at this point in the history

  7. Update base_spec without redundant variables

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    cb6ee07 View commit details
    Browse the repository at this point in the history

  8. Add surname and description to cities test table

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    2271ede View commit details
    Browse the repository at this point in the history

  9. Add fields/base spec without location field for geo_point type

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    8d8f1ae View commit details
    Browse the repository at this point in the history

  10. Split base #compose result check into 2 methods

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    02ceacd View commit details
    Browse the repository at this point in the history

  11. Remove spec of default spec behavior send nil when no field at all

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    235f77b View commit details
    Browse the repository at this point in the history

  12. Refactor base spec and trigger CI

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 26, 2021
    Configuration menu
    Copy the full SHA
    ff81e4e View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. Add spec for parental field with ignore_blank: true flag to fields/ba… 

    …se_spec
    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    0336f24 View commit details
    Browse the repository at this point in the history

  2. Add spec for parental field without ignore_blank: true flag to fields… 

    …/base_spec
    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    12fa1f1 View commit details
    Browse the repository at this point in the history

  3. Refactor fields/base_spec

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    619e172 View commit details
    Browse the repository at this point in the history

  4. Refactor lib/chewy/fields/base #compose key/value returning

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    3e59693 View commit details
    Browse the repository at this point in the history

  5. Assign hashes to variables in fields/base_spec

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    14fc202 View commit details
    Browse the repository at this point in the history

  6. Use inline return for if statement for #compose in fields/base

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    9b71f1b View commit details
    Browse the repository at this point in the history

  7. Rubocop: update type/witchcraft range definition

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    3dad3dd View commit details
    Browse the repository at this point in the history

  8. Rubocop: refactor fields/base_spec

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    2e69c18 View commit details
    Browse the repository at this point in the history

  9. Rubocop: refactor fields/base_spec hashes

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    996eb10 View commit details
    Browse the repository at this point in the history

  10. Rubocop: continue to refactor fields/base_spec hashes

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    2481339 View commit details
    Browse the repository at this point in the history

  11. Regenerate rubocop_todo to hide "Redundant begin block" offence for l… 

    …ib/chewy/search/request.rb
    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    9ae19ee View commit details
    Browse the repository at this point in the history

  12. Regenerate rubocop_todo to hide Ruby 3.0.0 offences

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    8e809f8 View commit details
    Browse the repository at this point in the history

  13. Update fields/base_spec to test parental and children fields with ign… 

    …ore_blank f
    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    82c198e View commit details
    Browse the repository at this point in the history

  14. Uncomment fields/base geo_point specs

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    fe3fa88 View commit details
    Browse the repository at this point in the history

  15. Update double quotes with single in fields/base_spec

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    243cde9 View commit details
    Browse the repository at this point in the history

  16. Avoid Style/RedundantBegin Rubocop check for Ruby 2.7.2

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    a049eba View commit details
    Browse the repository at this point in the history

  17. Add lib/chewy/type/witchcraft.rb to Lint/Syntax in rubocop_todo

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    7ee6832 View commit details
    Browse the repository at this point in the history

  18. Revert "Add lib/chewy/type/witchcraft.rb to Lint/Syntax in rubocop_todo" 

    This reverts commit 7ee6832.
    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    ccfcf2d View commit details
    Browse the repository at this point in the history

  19. Add lib/chewy/type/witchcraft.rb Style/SlicingWithRange to rubocop_todo

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    039b1f5 View commit details
    Browse the repository at this point in the history

  20. Describe error of sending {} as location in fields/base_spec

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    94a60f2 View commit details
    Browse the repository at this point in the history

  21. Rubocop remove space in fields/base_spec

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    1b5972a View commit details
    Browse the repository at this point in the history

  22. Comment 2nd way of local: {} definition for fields/base_spec

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    73f183f View commit details
    Browse the repository at this point in the history

  23. Fix arguments precedency

    Dalton committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    54dc3d5 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Fix geo_point type with ignore_blank: true flag in fields/base_spec

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    8f55209 View commit details
    Browse the repository at this point in the history

  2. Update Readme

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    9735359 View commit details
    Browse the repository at this point in the history

  3. Remove redundant space

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    1e6de4f View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    9f8e744 View commit details
    Browse the repository at this point in the history

  5. Replace field_with_empty_value? with result.empty? statement for fiel… 

    …ds/base_spec
    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    8423088 View commit details
    Browse the repository at this point in the history

  6. Replace .empty? with .blank? statement for fields/base_spec

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    16e4e91 View commit details
    Browse the repository at this point in the history

  7. Allow to pass ignore_blank params as string

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    4867524 View commit details
    Browse the repository at this point in the history

  8. Add spec for ignore_blank false for geo_point

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    5c4f3fb View commit details
    Browse the repository at this point in the history

  9. Add spec for geo_point ignore_blank:false

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    f5353a0 View commit details
    Browse the repository at this point in the history

  10. Updare response spec order for geo_point ignore_blank:false

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    075cc81 View commit details
    Browse the repository at this point in the history

  11. Update cities' surname field with historical_name field

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    934701e View commit details
    Browse the repository at this point in the history

  12. Remove adding of cities = [] to countries in fields/base_spec

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    ab89ca1 View commit details
    Browse the repository at this point in the history

  13. Split into 2 contents countries with and without cities

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    3cf59e5 View commit details
    Browse the repository at this point in the history

  14. Remove pry from gems

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    7854793 View commit details
    Browse the repository at this point in the history

  15. Rubocop spaces

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    7346ee8 View commit details
    Browse the repository at this point in the history

  16. Add specs for ignore_blank flag as string type

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    e1c92de View commit details
    Browse the repository at this point in the history

  17. Update rubocop_todo to avoid Lint/SymbolConversion string check

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    057b265 View commit details
    Browse the repository at this point in the history

  18. Update Readme Skip record fields during import section with default v… 

    …alue fro all types
    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    7f760b1 View commit details
    Browse the repository at this point in the history

  19. Update Changelog with ``

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    0e5940e View commit details
    Browse the repository at this point in the history

  20. Simplify #compose ignore_blank

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    4e29d64 View commit details
    Browse the repository at this point in the history

  21. Reorganize fields/base_spec contexts for ignore_blank option

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    2abc18c View commit details
    Browse the repository at this point in the history

  22. Rubocop it

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    0830cc7 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. Remove Rubocop Style/SlicingWithRange offence

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    d6fb747 View commit details
    Browse the repository at this point in the history

  2. Remove Rubocop Style/RedundantFreeze offence

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    9e657d2 View commit details
    Browse the repository at this point in the history

  3. Revert "Remove Rubocop Style/RedundantFreeze offence" 

    This reverts commit 9e657d2.
    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    901355f View commit details
    Browse the repository at this point in the history

  4. Remove Rubocop Style/RedundantBegin offence in lib/chewy/type/syncer.rb

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    172758d View commit details
    Browse the repository at this point in the history

  5. Remove Rubocop Style/RedundantBegin offence lib/chewy/search/request.rb

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    4a9e804 View commit details
    Browse the repository at this point in the history

  6. Add spec for with ignore_blank: false

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    a30139d View commit details
    Browse the repository at this point in the history

  7. Ruboco inline disable Lint/SymbolConversion for fields/base_spec for … 

    …string key spec
    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    f0dffe3 View commit details
    Browse the repository at this point in the history

  8. Regenerate rubocop_todo

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    bcb4326 View commit details
    Browse the repository at this point in the history

  9. Update target Ruby version in rubocop.yml

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    56b4361 View commit details
    Browse the repository at this point in the history

  10. Remove Rubocop Style/RedundantBegin offence for 2.7 and Rubocop versi… 

    …on 1.11.0
    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    8b3fb90 View commit details
    Browse the repository at this point in the history

  11. Update changelog with gramma

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    ffe7a3c View commit details
    Browse the repository at this point in the history

  12. Update readme with gramma

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    7c88fca View commit details
    Browse the repository at this point in the history

  13. Update gramma and remove redundant check from fields/base_spec.rb

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    d472fde View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2021

  1. Update Rubocop TargetRubyVersion to 2.6

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    cdbf68a View commit details
    Browse the repository at this point in the history

  2. Change compatibility with MRI from 2.5-3.0 to 2.6-3.0

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    4e6e3f9 View commit details
    Browse the repository at this point in the history

  3. Mark in CHANGELOG dropping of Ruby 2.5 support

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    61d67cc View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG letter to uppercase in changes section

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    e7ba698 View commit details
    Browse the repository at this point in the history

  5. Update rubocop_todo with $ rubocop --auto-gen-config

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    df3ac19 View commit details
    Browse the repository at this point in the history

  6. Try to launch CI without new .ruby-version file

    @Vitalina-Vakulchyk
    Vitalina-Vakulchyk committed Apr 2, 2021
    Configuration menu
    Copy the full SHA
    ef2ce52 View commit details
    Browse the repository at this point in the history