Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore empty blank options on fields #778

Merged
merged 77 commits into from
Apr 2, 2021
Merged

Ignore empty blank options on fields #778

merged 77 commits into from
Apr 2, 2021

Conversation

Vitalina-Vakulchyk
Copy link
Contributor

@Vitalina-Vakulchyk Vitalina-Vakulchyk commented Mar 26, 2021 •
edited
Loading

Add :ignore_blank option to not pass fields when we have field responds true to .empty? method

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Updated tests.
  • Added an entry to the changelog if the new code introduces user-observable changes. See changelog entry format for details.

@Vitalina-Vakulchyk
Add geo_point location field to base_spec.rb
c5ad207
@Vitalina-Vakulchyk
Add geo_point expect to spec
b58356a
@Vitalina-Vakulchyk
Add field ignore_blank flag with ability to skip fields with .blank…
1e0fa94 
…? values
@Vitalina-Vakulchyk
Add ignore_blank to geo_point field spec in /spec/chewy/fields/base_s…
bbebecb 
…pec.rb
@Vitalina-Vakulchyk
Merge branch 'master' into ignore-empty-blank-options-on-fields
bdf6d67
@Vitalina-Vakulchyk
Reorganize base_spec objects and scopes section
ab8cca5
@Vitalina-Vakulchyk
Add geo_point type without ignore_blank: true flag spec
f7cf5d3
@Vitalina-Vakulchyk
Update base_spec without redundant variables
cb6ee07
@Vitalina-Vakulchyk
Add surname and description to cities test table
2271ede
@Vitalina-Vakulchyk
Add fields/base spec without location field for geo_point type
8d8f1ae
@Vitalina-Vakulchyk
Split base #compose result check into 2 methods
02ceacd
@Vitalina-Vakulchyk
Remove spec of default spec behavior send nil when no field at all
235f77b
@Vitalina-Vakulchyk
Refactor base spec and trigger CI
ff81e4e
@Vitalina-Vakulchyk Vitalina-Vakulchyk force-pushed the ignore-empty-blank-options-on-fields branch from 43fb72b to ff81e4e Compare March 26, 2021 15:47
@Vitalina-Vakulchyk
Add spec for parental field with ignore_blank: true flag to fields/ba…
0336f24 
…se_spec
@Vitalina-Vakulchyk
Add spec for parental field without ignore_blank: true flag to fields…
12fa1f1 
…/base_spec
@Vitalina-Vakulchyk
Refactor fields/base_spec
619e172
@Vitalina-Vakulchyk
Refactor lib/chewy/fields/base #compose key/value returning
3e59693
@Vitalina-Vakulchyk
Assign hashes to variables in fields/base_spec
14fc202
@Vitalina-Vakulchyk
Use inline return for if statement for #compose in fields/base
9b71f1b
@Vitalina-Vakulchyk
Rubocop: update type/witchcraft range definition
3dad3dd
@Vitalina-Vakulchyk
Rubocop: refactor fields/base_spec
2e69c18
@Vitalina-Vakulchyk
Rubocop: refactor fields/base_spec hashes
996eb10
@Vitalina-Vakulchyk
Rubocop: continue to refactor fields/base_spec hashes
2481339
@Vitalina-Vakulchyk
Regenerate rubocop_todo to hide "Redundant begin block" offence for l…
9ae19ee 
…ib/chewy/search/request.rb
@Vitalina-Vakulchyk
Regenerate rubocop_todo to hide Ruby 3.0.0 offences
8e809f8
@Vitalina-Vakulchyk
Update fields/base_spec to test parental and children fields with ign…
82c198e 
…ore_blank f
@Vitalina-Vakulchyk
Uncomment fields/base geo_point specs
fe3fa88
@Vitalina-Vakulchyk
Update double quotes with single in fields/base_spec
243cde9
@Vitalina-Vakulchyk
Avoid Style/RedundantBegin Rubocop check for Ruby 2.7.2
a049eba
@Vitalina-Vakulchyk Vitalina-Vakulchyk force-pushed the ignore-empty-blank-options-on-fields branch from 1f616f5 to 56b4361 Compare March 31, 2021 08:11
@Vitalina-Vakulchyk
Copy link
Contributor Author

Vitalina-Vakulchyk commented Mar 31, 2021 •
edited
Loading

@rabotyaga @barthez @AlexVPopov
Thank you for the comments! Please take a look again.

rabotyaga
rabotyaga approved these changes Mar 31, 2021
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
spec/chewy/fields/base_spec.rb Outdated Show resolved Hide resolved
spec/chewy/fields/base_spec.rb Outdated Show resolved Hide resolved
spec/chewy/fields/base_spec.rb Outdated Show resolved Hide resolved
spec/chewy/fields/base_spec.rb Outdated Show resolved Hide resolved
spec/chewy/fields/base_spec.rb Outdated Show resolved Hide resolved
@Vitalina-Vakulchyk
Copy link
Contributor Author

Vitalina-Vakulchyk commented Apr 2, 2021 •
edited
Loading

Dropping 2.5 support as its EOL passed on 31-03-2021.

@Vitalina-Vakulchyk Vitalina-Vakulchyk merged commit 1b54be4 into master Apr 2, 2021
@Vitalina-Vakulchyk Vitalina-Vakulchyk deleted the ignore-empty-blank-options-on-fields branch April 2, 2021 13:09
rabotyaga pushed a commit that referenced this pull request Apr 2, 2021
@Vitalina-Vakulchyk
Add ignore_blank option to field method. Drop support for Ruby 2.5 (
fe5e411 
#778)
Vitalina-Vakulchyk added a commit that referenced this pull request Apr 2, 2021
@Vitalina-Vakulchyk
Ignore empty blank options on fields (#778)
6f31d43
@AlexVPopov AlexVPopov linked an issue Apr 5, 2021 that may be closed by this pull request
Skip fields from record while import #195
Closed
@AlexVPopov AlexVPopov mentioned this pull request Apr 5, 2021
Closed
cyucelen pushed a commit to cyucelen/chewy that referenced this pull request Jan 28, 2023
@Vitalina-Vakulchyk
Add ignore_blank option to field method. Drop support for Ruby 2.5 (
6871973 
toptal#778)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabotyaga rabotyaga rabotyaga approved these changes

@dalthon dalthon dalthon approved these changes

@AlexVPopov AlexVPopov AlexVPopov approved these changes

@barthez barthez barthez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip fields from record while import
5 participants
@Vitalina-Vakulchyk @barthez @dalthon @AlexVPopov @rabotyaga