Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for namespaced indexes in journaling #432

Merged
merged 2 commits into from
Sep 27, 2016
Merged

Add support for namespaced indexes in journaling #432

merged 2 commits into from
Sep 27, 2016

Conversation

fpbouchard
Copy link

Fixes #431. Let me know what you think. Thanks!

@pyromaniac
Copy link
Contributor

pyromaniac commented Sep 26, 2016

Wow. Exactly what I was thinking of. Almost. I was going to call it reference and join 2 journal columns in one with #, but I think we can start with your patch :) Going to review specs later and merge it. Awesome job, thanks!

@pyromaniac
Copy link
Contributor

Can you fix rubocop complains please?

@fpbouchard
Copy link
Author

Sorry about that.

@pyromaniac pyromaniac merged commit 1666e99 into toptal:master Sep 27, 2016
@pyromaniac
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants