Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with journaling and indexes in modules #431

Closed
fpbouchard opened this issue Sep 23, 2016 · 1 comment
Closed

Problems with journaling and indexes in modules #431

fpbouchard opened this issue Sep 23, 2016 · 1 comment

Comments

@fpbouchard
Copy link

Hi, we are having issues with apply_changes_from with journaling with indexes inside modules.

The way the index is serialized is using _index_name which calls demodulize. Then, when replaying the journal, derive_type is called to infer the index, but it is missing the module. derive_type does work with modules using the slash notation: module/index#type.

We are wondering if the fix should be in _index_name or in the way the index is serialized in the journal.

Any thoughts?
P.S. I did want to create a spec to reproduce the issue, but I can't seem to run the specs on master. bundle doesn't work:

You have requested:
listen ~> 3.0.0

The bundle currently has listen locked at 2.10.0.
Try running bundle update listen

If you are updating multiple gems in your Gemfile at once,
try passing them all to bundle update

@pyromaniac
Copy link
Contributor

Yeah, probably _index_name have to be fixed. Actually, there should be even another method used because _index_name have a specific meaning.

As for bundler, just try bundle update, should help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants