Silence rubocop warning about unnecessay splat expansion #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the expansion is needed here, unless one would change the code - because rubocop does not recognize that this is needed, it should be ok to disable this cop for this line using an end-of-line comment
|
I was going to ask you to do it, but can you use |
|
@pyromaniac done |
|
Perfect, will merge as soon as specs will pass, thanks, at least one build :) |
msievers
deleted the
rubocop/fix_wrong_unneeded_splat_expansion_warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, running rubocop results in
ok to disable this cop for this line using an end-of-line comment
@pyromaniac I would like to request to merge this or an equivalent fix soon, so that I can rebase #428 with this. Currently all tests on travis seem to fail only because of this single rubocop warning.