Make journals work with elasticsearch 2.x #428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the specs with elasticsearch 2.1.2 reveals an error in spec/chewy/index/actions_spec#413
Digging into this with
pry
reveals the following error while executingimport
The problem arises because
created_at
is a date with the formatbasic_date_time
This is ok for elasticsearch < 2, because
For elasticsearch > 2 it isn't ok, because the given epoch does not match the specified format.
My solution for this is to drop the
format
specification and let the mapping simply state thatcreated_at
is a date"strict_date_optional_time||epoch_millis"