Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

fix: invalid version number when running yvm use to auto-install version from .yvmrc file #277

Merged
merged 2 commits into from
Jan 6, 2019

Conversation

umar-ahmed
Copy link
Contributor

Description

  • On a fresh install of YVM, when I was running yvm use in a project that had a .yvmrc file, I expected it to auto-install the version and it failed instead
  • After tracing the code path, I discovered that installVersion was being called with incorrect arguments

DevQA

DevQA Prep

DevQA Steps

  • Run make install
  • Create a folder with a .yvmrc file
  • In the rc file, put a version number that you don't already have installed
  • Run yvm use
  • Verify that it downloads and installs the specified Yarn version and enables it

Comments:

@umar-ahmed
Copy link
Contributor Author

@jakebolam it seems like Circle is using the latest yvm release which contains the bug that this PR is trying to fix. Anything that can be done about that from your end?

@jakebolam
Copy link
Contributor

@umar-ahmed thanks for catching this, I've pinned the version in CI temporarily.

@jakebolam jakebolam merged commit 6ff4060 into tophat:master Jan 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants