Skip to content

fix(PM-2609): show respective scorecard types for respective review type #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2025
Merged

fix(PM-2609): show respective scorecard types for respective review type #1698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/ChallengeEditor/ChallengeReviewer-Field/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,9 @@ class ChallengeReviewerField extends Component {
const { challenge, metadata = {}, readOnly = false } = this.props
const { scorecards = [], workflows = [] } = metadata
const validationErrors = challenge.submitTriggered ? this.validateReviewer(reviewer) : {}
const selectedPhase = challenge.phases.find(p => p.phaseId === reviewer.phaseId)
Copy link

@github-actions github-actions bot Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
The selectedPhase variable is assigned using find, which will return undefined if no matching phase is found. This could lead to potential runtime errors when accessing properties of selectedPhase later in the code. Consider adding a check to handle the case where selectedPhase is undefined.

const isDesignChallenge = challenge && challenge.trackId === DES_TRACK_ID
const filteredScorecards = scorecards.filter(item => item.type?.toLowerCase() === selectedPhase?.name.toLowerCase());
Copy link

@github-actions github-actions bot Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
The filteredScorecards array is filtered based on selectedPhase?.name.toLowerCase(). If selectedPhase is undefined, this will result in an error. Ensure selectedPhase is not undefined before attempting to access its properties.


return (
<div key={`reviewer-${index}`} className={styles.reviewerForm}>
Expand Down Expand Up @@ -666,7 +668,7 @@ class ChallengeReviewerField extends Component {
onChange={(e) => this.updateReviewer(index, 'scorecardId', e.target.value)}
>
<option value=''>Select Scorecard</option>
{scorecards.map(scorecard => (
{filteredScorecards.map(scorecard => (
<option key={scorecard.id} value={scorecard.id}>
{scorecard.name || 'Unknown'} - {scorecard.type || 'Unknown'} ({scorecard.challengeTrack || 'Unknown'}) v{scorecard.version || 'Unknown'}
</option>
Expand Down