fix(PM-2609): show respective scorecard types for respective review type #1698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const { challenge, metadata = {}, readOnly = false } = this.props | ||
| const { scorecards = [], workflows = [] } = metadata | ||
| const validationErrors = challenge.submitTriggered ? this.validateReviewer(reviewer) : {} | ||
| const selectedPhase = challenge.phases.find(p => p.phaseId === reviewer.phaseId) |
There was a problem hiding this comment.
[❗❗ correctness]
The selectedPhase variable is assigned using find, which will return undefined if no matching phase is found. This could lead to potential runtime errors when accessing properties of selectedPhase later in the code. Consider adding a check to handle the case where selectedPhase is undefined.
| const validationErrors = challenge.submitTriggered ? this.validateReviewer(reviewer) : {} | ||
| const selectedPhase = challenge.phases.find(p => p.phaseId === reviewer.phaseId) | ||
| const isDesignChallenge = challenge && challenge.trackId === DES_TRACK_ID | ||
| const filteredScorecards = scorecards.filter(item => item.type?.toLowerCase() === selectedPhase?.name.toLowerCase()); |
There was a problem hiding this comment.
[❗❗ correctness]
The filteredScorecards array is filtered based on selectedPhase?.name.toLowerCase(). If selectedPhase is undefined, this will result in an error. Ensure selectedPhase is not undefined before attempting to access its properties.
jmgasper
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Ticket link - https://topcoder.atlassian.net/browse/PM-2609