feat(toml)!: Update generator by using toml_edit
#470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the other main half of toml-rs#340. Still have deprecations and tests left Note that strings are rendered differently, see toml-rs#287 By extension this also finishes up toml-rs#396. BREAKING CHANGES - `impl Display for toml::Value` now renders as values, not documents, see instead `Table` - `toml::ser::Serializer` only serializes documents, instead see `toml::ser::ValueSerializer` - `toml::ser::tables_last` is removed, no longer needed - `toml::ser::to_vec` is removed to mirror the loss of `from_slice` - atm `toml::ser::to_string_pretty` just causes larger arrays to be indented - `toml::ser::Error` is now opaque - `toml::ser::Serializer::pretty_string` was removed - `toml::ser::Serializer::pretty_string_literal` was removed - `toml::ser::Serializer::pretty_array` was removed - `toml::ser::Serializer::pretty_array_indent` was removed - `toml::ser::Serializer::pretty_array_trailing_comma` was removed - `toml::ser::Serializer` is now used used by value, rather than `&mut` Fixes toml-rs#396
epage
added a commit
to epage/toml_edit
that referenced
this pull request
Jan 19, 2023
With toml-rs#470, we more reliably generate valid output. Fixes toml-rs#387
epage
added a commit
to epage/toml_edit
that referenced
this pull request
Jan 19, 2023
With toml-rs#470, we've changed out generator so we avoid ValueAfterTable errors. Fixes toml-rs#356
epage
added a commit
to epage/toml_edit
that referenced
this pull request
Jan 19, 2023
With toml-rs#470, we changed our generator which can handle more cases Fixes toml-rs#403
|
what should be used instead of |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the other main half of #340. Still have deprecations and tests left
Note that strings are rendered differently, see #287
By extension this also finishes up #396.
BREAKING CHANGES
impl Display for toml::Valuenow renders as values, not documents, see insteadTabletoml::ser::Serializeronly serializes documents, instead seetoml::ser::ValueSerializertoml::ser::tables_lastis removed, no longer neededtoml::ser::to_vecis removed to mirror the loss offrom_slicetoml::ser::to_string_prettyjust causes larger arrays to be indentedtoml::ser::Erroris now opaquetoml::ser::Serializer::pretty_stringwas removedtoml::ser::Serializer::pretty_string_literalwas removedtoml::ser::Serializer::pretty_arraywas removedtoml::ser::Serializer::pretty_array_indentwas removedtoml::ser::Serializer::pretty_array_trailing_commawas removedtoml::ser::Serializeris now used used by value, rather than&mutFixes #396