Rendering of strings doesn't match toml-rs #287
Comments
4 tasks
epage
added a commit
to epage/toml_edit
that referenced
this issue
Jan 19, 2023
This is the other main half of toml-rs#340. Still have deprecations and tests left Note that strings are rendered differently, see toml-rs#287 By extension this also finishes up toml-rs#396. BREAKING CHANGES - `impl Display for toml::Value` now renders as values, not documents, see instead `Table` - `toml::ser::Serializer` only serializes documents, instead see `toml::ser::ValueSerializer` - `toml::ser::tables_last` is removed, no longer needed - `toml::ser::to_vec` is removed to mirror the loss of `from_slice` - atm `toml::ser::to_string_pretty` just causes larger arrays to be indented - `toml::ser::Error` is now opaque - `toml::ser::Serializer::pretty_string` was removed - `toml::ser::Serializer::pretty_string_literal` was removed - `toml::ser::Serializer::pretty_array` was removed - `toml::ser::Serializer::pretty_array_indent` was removed - `toml::ser::Serializer::pretty_array_trailing_comma` was removed - `toml::ser::Serializer` is now used used by value, rather than `&mut` Fixes toml-rs#396
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While we intentionally chose to prefer
"over'when no escaping is needed (because this is most likely what users will do), we should probably use"""to avoid quoting"in strings.We also need to look into our
\thandling.Compare
Note: This only impacts content we auto-generate formatting for. We still preserve a users formatting when roundtripping through the format-preserving API.
The text was updated successfully, but these errors were encountered: