Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RouteData issue and refactor core classes #214

Merged
merged 11 commits into from
Oct 13, 2021
Merged

Conversation

tomgilder
Copy link
Owner

No description provided.

@tomgilder tomgilder changed the title Refactor names Fix RouteData issue and refactor core classes Oct 11, 2021
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #214 (6fad2ce) into main (456b966) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   99.27%   99.49%   +0.21%     
==========================================
  Files          18       18              
  Lines         965      984      +19     
==========================================
+ Hits          958      979      +21     
+ Misses          7        5       -2     
Impacted Files Coverage Δ
lib/routemaster.dart 99.50% <100.00%> (+<0.01%) ⬆️
lib/src/pages/page_stack.dart 100.00% <100.00%> (ø)
lib/src/pages/pages.dart 100.00% <100.00%> (ø)
lib/src/pages/stack_page.dart 100.00% <100.00%> (ø)
lib/src/pages/tab_pages.dart 100.00% <100.00%> (ø)
lib/src/route_data.dart 100.00% <100.00%> (ø)
lib/src/pages/transition_page.dart 100.00% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 456b966...6fad2ce. Read the comment docs.

@tomgilder tomgilder merged commit 261b716 into main Oct 13, 2021
@tomgilder tomgilder deleted the route-data-fix branch October 13, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant