Make page transitions const (#213)

tomgilder · Oct 7, 2021 · 456b966 · 456b966
1 parent 74f928f
commit 456b966
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/lib/src/pages/transition_page.dart b/lib/src/pages/transition_page.dart
@@ -14,16 +14,16 @@ abstract class PageTransition {
   Duration get duration;
 
   /// A transition with no animation.
-  static PageTransition get none => const _NoPageTransition();
+  static const PageTransition none = _NoPageTransition();
 
   /// The default fade upwards transition used on Android.
-  static PageTransition get fadeUpwards => const _FadeUpwardsPageTransition();
+  static const PageTransition fadeUpwards = _FadeUpwardsPageTransition();
 
   /// The default slide-in transition used on iOS.
-  static PageTransition get cupertino => const _CupertinoPageTransition();
+  static const PageTransition cupertino = _CupertinoPageTransition();
 
   /// A zoom transition matching the one used on Android 10.
-  static PageTransition get zoom => const _ZoomPageTransition();
+  static const PageTransition zoom = _ZoomPageTransition();
 
   /// Returns the default page transition for the given [platform].
   static PageTransition platformDefault(TargetPlatform platform) {

diff --git a/test/transition_test.dart b/test/transition_test.dart
@@ -42,7 +42,7 @@ void main() {
   });
 
   test('Zoom transition is correct', () {
-    final zoomTransition = PageTransition.zoom;
+    const zoomTransition = PageTransition.zoom;
     expect(zoomTransition.duration, const Duration(milliseconds: 300));
     expect(
       zoomTransition.transitionsBuilder,
@@ -212,8 +212,8 @@ void main() {
         routesBuilder: (_) => RouteMap(
           routes: {
             '/': (info) => const MaterialPageOne(),
-            '/subpage': (info) => TransitionPage<void>(
-                  child: const PageTwo(),
+            '/subpage': (info) => const TransitionPage<void>(
+                  child: PageTwo(),
                   pushTransition: PageTransition.none,
                   popTransition: PageTransition.none,
                 ),
@@ -258,8 +258,8 @@ void main() {
         routesBuilder: (_) => RouteMap(
           routes: {
             '/': (info) => const MaterialPageOne(),
-            '/subpage': (info) => TransitionPage<void>(
-                  child: const PageTwo(),
+            '/subpage': (info) => const TransitionPage<void>(
+                  child: PageTwo(),
                   pushTransition: PageTransition.fadeUpwards,
                   popTransition: PageTransition.cupertino,
                 ),