Skip to content

flame: remove unused imports from README example #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2022
Merged

flame: remove unused imports from README example #1836

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6b546d
flame: remove unused imports from README example
Tamschi Jan 14, 2022
065f2b3
Merge branch 'master' into patch-1
hawkw Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tracing-flame/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,8 @@ of the `FlameLayer`, see the docs for [`FlushGuard`].
## Layer Setup

```rust
use std::{fs::File, io::BufWriter};
use tracing_flame::FlameLayer;
use tracing_subscriber::{registry::Registry, prelude::*, fmt};
use tracing_subscriber::{prelude::*, fmt};

fn setup_global_subscriber() -> impl Drop {
Copy link
Contributor Author

@Tamschi Tamschi Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's incidental, but this example would have been easier for me to understand without type annotations if there was a #[must_use] on this function (since impl Drop appears to cause that warning to not propagate here) and _guard was flush_guard instead.

let fmt_layer = fmt::Layer::default();
Expand Down