flame: remove unused imports from README example #1836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tamschi
commented
Jan 14, 2022
| use tracing_subscriber::{registry::Registry, prelude::*, fmt}; | ||
| use tracing_subscriber::{prelude::*, fmt}; | ||
|
|
||
| fn setup_global_subscriber() -> impl Drop { |
Contributor
Author
There was a problem hiding this comment.
It's incidental, but this example would have been easier for me to understand without type annotations if there was a #[must_use] on this function (since impl Drop appears to cause that warning to not propagate here) and _guard was flush_guard instead.
hawkw
pushed a commit
that referenced
this pull request
Feb 3, 2022
## Motivation While writing a component tracing example, I noticed that these imports were giving me `unused_imports` warnings. It seems they aren't necessary anymore. ## Solution I removed the unused imports in this example.
hawkw
pushed a commit
that referenced
this pull request
Feb 3, 2022
## Motivation While writing a component tracing example, I noticed that these imports were giving me `unused_imports` warnings. It seems they aren't necessary anymore. ## Solution I removed the unused imports in this example.
hawkw
pushed a commit
that referenced
this pull request
Feb 3, 2022
## Motivation While writing a component tracing example, I noticed that these imports were giving me `unused_imports` warnings. It seems they aren't necessary anymore. ## Solution I removed the unused imports in this example.
hawkw
pushed a commit
that referenced
this pull request
Feb 3, 2022
## Motivation While writing a component tracing example, I noticed that these imports were giving me `unused_imports` warnings. It seems they aren't necessary anymore. ## Solution I removed the unused imports in this example.
hawkw
pushed a commit
that referenced
this pull request
Feb 4, 2022
## Motivation While writing a component tracing example, I noticed that these imports were giving me `unused_imports` warnings. It seems they aren't necessary anymore. ## Solution I removed the unused imports in this example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While writing a component tracing example, I noticed that these imports were giving me
unused_importswarnings. It seems they aren't necessary anymore.Solution
I removed the unused imports in this example.