Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove i64_histogram support #99

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

rbtcollins
Copy link
Contributor

rust-opentelemetry has dropped this, as it is
recommended against by the otel spec.

rust-opentelemetry has dropped this, as it is
recommended against by the otel spec.
@rbtcollins
Copy link
Contributor Author

I'm not sure what to do with i64 histogram. prefixed metrics - this patch just degrades to a kv store, but this is really a silent API break :/

Copy link
Collaborator

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to add a changelog entry for this? Also probably worth emitting a warning or have some behavior or some users may be confused

@djc
Copy link
Collaborator

djc commented Feb 26, 2024

This is part of #100.

@jtescher jtescher merged commit 6cdd4d7 into tokio-rs:v0.1.x Feb 27, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants