-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to opentelemetry 0.22 #100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, seems like the jaeger -> otlp exporter switch needs to happen to avoid the deprecation errors
I was suggesting just removing the Jaeger example -- are you saying it should be switched to OTLP? (I noticed there's already a fairly elaborate OTLP setup in one of the other examples, so not sure it makes sense to have both.) |
Can remove too, whichever is easier |
0da934a
to
c2437bc
Compare
@@ -35,6 +35,7 @@ once_cell = "1.13.0" | |||
|
|||
# Fix minimal-versions | |||
async-trait = { version = "0.1.56", optional = true } | |||
futures-util = { version = "0.3.17", optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it makes to continue to pursue minimal-versions here if we don't have a similar CI job in the upstream opentelemetry repo to keep it from regressing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah true
I think like asked for in #99 the silent API break of i64 histograms should be added to a Changelog entry. Something like
|
I've added a changelog entry and bumped the version number. @jtescher do you think this is good to release? |
CI failure is Cow imported twice. |
Yeah, was looking at this last night but it's not actually clear to me where the second (or rather, the first) import is. |
A |
The Jaeger crate is soft-deprecated in favor of using the OTLP protocol to talk to Jaeger. Since we already have an otlp example here, remove the Jaeger example.
opentelemetry-sdk apparently is not getting checked for minimal versions upstream, and now depends on a Stream export in the root of futures-util that didn't exist in early versions of that crate. Require 0.3.17, which appears to be the version that introduced the top-level re-exports.
Ahh, that explains it, thanks! |
Hi! Can this be merged now? |
(@jtescher also, I would be happy to help maintaining this if you're running short on time/energy.) |
@djc thanks! I don't have admin on this repo, could get added in discord maybe? but I made you an owner on crates.io 👍 |
Motivation
Would like to upgrade to opentelemetry 0.22.
Solution
This seems mostly straightforward. Upstream deprecated
opentelemetry_jaeger::new_pipeline()
(which is used in an example) in favor of the OTLP collector for Jaeger; given that we already have an OTLP example should we just delete it?