Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize refactor #696

Merged
merged 8 commits into from
Apr 24, 2024
Merged

Resize refactor #696

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
22dd583
use checked_sub
braddunbar Apr 21, 2024
dffdeaf
return when additional == 0
braddunbar Apr 21, 2024
f247f2d
move safe operation out of unsafe block
braddunbar Apr 21, 2024
8a62462
use spare_capacity_mut instead of chunk_mut
braddunbar Apr 21, 2024
0096b25
Add safety comments
braddunbar Apr 21, 2024
a1d0cc6
refactor to use guard clauses
braddunbar Apr 21, 2024
63bca89
use if-let instead of unwrap
braddunbar Apr 21, 2024
434166a
reduce scope of unsafe blocks
braddunbar Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
use checked_sub
  • Loading branch information
@braddunbar
braddunbar committed Apr 21, 2024
commit 22dd5839741c88295c1b64d71b1f620056cf51cb
4 changes: 1 addition & 3 deletions src/bytes_mut.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,9 +468,7 @@ impl BytesMut {
/// assert_eq!(&buf[..], &[0x1, 0x1, 0x3, 0x3]);
/// ```
pub fn resize(&mut self, new_len: usize, value: u8) {
let len = self.len();
if new_len > len {
let additional = new_len - len;
if let Some(additional) = new_len.checked_sub(self.len()) {
self.reserve(additional);
unsafe {
let dst = self.chunk_mut().as_mut_ptr();
Expand Down