Resize refactor #696
Merged
Resize refactor #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to check capacity because it's already been reserved above.
This would be better written with let-else, but we won't get that until `MSRV >= 1.65.x`.
Darksonn
reviewed
Apr 22, 2024
Co-authored-by: Alice Ryhl <aliceryhl@google.com>
Darksonn
approved these changes
Apr 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done a little refactoring of
BytesMut:resizehere to increase clarity, handle a few edge cases, and explicitly state soundness assumptions about unsafe code.As I stated in my commits, this would be nicer with a
let-elseblock, but that isn't currently covered by our MSRV.