Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deletion behavior in DocsPanel component #6511

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

congzhou09
Copy link
Contributor

@congzhou09 congzhou09 commented Mar 19, 2024

Modification(destination):

  1. Click deleteDoc button will not trigger the click callback for doc-switching.
  2. Switch to a default doc only after deleteing the editor's current doc.
  3. Do not show deleteDoc button when there's only one doc left.

before:

before.mp4

after:

after.mp4

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 8:07am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
blocksuite-docs ⬜️ Ignored (Inspect) Visit Preview Mar 19, 2024 8:07am

Copy link
Member

@doodlewind doodlewind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the help fixing list reactivity!

@doodlewind doodlewind merged commit 75680fe into toeverything:master Mar 19, 2024
19 checks passed
Brooooooklyn pushed a commit to toeverything/AFFiNE that referenced this pull request Mar 25, 2024
## Features
- toeverything/blocksuite#6544 @golok727
- toeverything/blocksuite#6543 @golok727
- toeverything/blocksuite#6536 @donteatfriedrice
- toeverything/blocksuite#6497 @doouding
- toeverything/blocksuite#6514 @regischen
- toeverything/blocksuite#6523 @donteatfriedrice
- toeverything/blocksuite#6530 @zzj3720
- toeverything/blocksuite#6526 @fourdim
- toeverything/blocksuite#6532 @donteatfriedrice
- toeverything/blocksuite#6493 @golok727
- toeverything/blocksuite#6529 @zzj3720
- toeverything/blocksuite#6528 @zzj3720
- toeverything/blocksuite#6509 @zzj3720
- toeverything/blocksuite#6525 @doodlewind
- toeverything/blocksuite#6502 @donteatfriedrice
- toeverything/blocksuite#6489 @Flrande

## Bugfix
- toeverything/blocksuite#6558 @fourdim
- toeverything/blocksuite#6556 @fourdim
- toeverything/blocksuite#6547 @fundon
- toeverything/blocksuite#6537 @golok727
- toeverything/blocksuite#6531 @donteatfriedrice
- toeverything/blocksuite#6524 @doodlewind
- toeverything/blocksuite#6519 @regischen
- toeverything/blocksuite#6517 @doodlewind
- toeverything/blocksuite#6516 @doodlewind
- toeverything/blocksuite#6510 @donteatfriedrice
- toeverything/blocksuite#6511 @congzhou09
- toeverything/blocksuite#6507 @doouding
- toeverything/blocksuite#6500 @fourdim
- toeverything/blocksuite#6486 @congzhou09
- toeverything/blocksuite#6495 @donteatfriedrice
- toeverything/blocksuite#6488 @Saul-Mirone
- toeverything/blocksuite#6482 @Flrande
- toeverything/blocksuite#6558 @fourdim

## Refactor
- toeverything/blocksuite#6548 @doodlewind
- toeverything/blocksuite#6522 @doodlewind
- toeverything/blocksuite#6518 @regischen
- toeverything/blocksuite#6521 @Saul-Mirone

## Misc
- toeverything/blocksuite#6557 @fourdim
- toeverything/blocksuite#6546 @Flrande
- docs: update package desc
- toeverything/blocksuite#6527 @fourdim
- toeverything/blocksuite#6505 @Brooooooklyn
- toeverything/blocksuite#6503 @fourdim
- v0.13.0
- toeverything/blocksuite#6496 @doodlewind
- toeverything/blocksuite#6562 @donteatfriedrice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants