feat(edgeless): copilot selection widget #6497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
doodlewind
reviewed
Mar 19, 2024
|
I was thinking of using stacked PR. Different features would be in different PRs but they all base on this PR and this PR will get merged once all its sub-PRs is ready. |
doodlewind
reviewed
Mar 22, 2024
doodlewind
reviewed
Mar 22, 2024
| export const AFFINE_EDGELESS_AI_WIDGET = 'affine-edgeless-ai-widget'; | ||
|
|
||
| @customElement('affine-edgeless-ai-widget') | ||
| export class EdgeelssAIWidget extends WidgetElement<EdgelessRootBlockComponent> { |
There was a problem hiding this comment.
The ai-tool.ts sounds too broad. Making it CopilotSelectionTool and 'affine-copilot-selection-widget' here should fit better with current tools naming.
(Let's avoid the concept of "ai" in naming since we are using unified "copilot" concept)
doodlewind
reviewed
Mar 22, 2024
packages/blocks/src/_common/types.ts
Outdated
| @@ -239,7 +243,8 @@ export type EdgelessTool = | |||
| | ConnectorTool | |||
| | EraserTool | |||
| | FrameTool | |||
| | FrameNavigatorTool; | |||
| | FrameNavigatorTool | |||
| | AITool; | |||
doodlewind
changed the title
doodlewind
approved these changes
Mar 22, 2024
Brooooooklyn
pushed a commit
to toeverything/AFFiNE
that referenced
this pull request
Mar 25, 2024
## Features - toeverything/blocksuite#6544 @golok727 - toeverything/blocksuite#6543 @golok727 - toeverything/blocksuite#6536 @donteatfriedrice - toeverything/blocksuite#6497 @doouding - toeverything/blocksuite#6514 @regischen - toeverything/blocksuite#6523 @donteatfriedrice - toeverything/blocksuite#6530 @zzj3720 - toeverything/blocksuite#6526 @fourdim - toeverything/blocksuite#6532 @donteatfriedrice - toeverything/blocksuite#6493 @golok727 - toeverything/blocksuite#6529 @zzj3720 - toeverything/blocksuite#6528 @zzj3720 - toeverything/blocksuite#6509 @zzj3720 - toeverything/blocksuite#6525 @doodlewind - toeverything/blocksuite#6502 @donteatfriedrice - toeverything/blocksuite#6489 @Flrande ## Bugfix - toeverything/blocksuite#6558 @fourdim - toeverything/blocksuite#6556 @fourdim - toeverything/blocksuite#6547 @fundon - toeverything/blocksuite#6537 @golok727 - toeverything/blocksuite#6531 @donteatfriedrice - toeverything/blocksuite#6524 @doodlewind - toeverything/blocksuite#6519 @regischen - toeverything/blocksuite#6517 @doodlewind - toeverything/blocksuite#6516 @doodlewind - toeverything/blocksuite#6510 @donteatfriedrice - toeverything/blocksuite#6511 @congzhou09 - toeverything/blocksuite#6507 @doouding - toeverything/blocksuite#6500 @fourdim - toeverything/blocksuite#6486 @congzhou09 - toeverything/blocksuite#6495 @donteatfriedrice - toeverything/blocksuite#6488 @Saul-Mirone - toeverything/blocksuite#6482 @Flrande - toeverything/blocksuite#6558 @fourdim ## Refactor - toeverything/blocksuite#6548 @doodlewind - toeverything/blocksuite#6522 @doodlewind - toeverything/blocksuite#6518 @regischen - toeverything/blocksuite#6521 @Saul-Mirone ## Misc - toeverything/blocksuite#6557 @fourdim - toeverything/blocksuite#6546 @Flrande - docs: update package desc - toeverything/blocksuite#6527 @fourdim - toeverything/blocksuite#6505 @Brooooooklyn - toeverything/blocksuite#6503 @fourdim - v0.13.0 - toeverything/blocksuite#6496 @doodlewind - toeverything/blocksuite#6562 @donteatfriedrice
congzhou09
reviewed
Mar 27, 2024
| ) { | ||
| const isRightButton = isRightButtonPressed(pointEvt); | ||
| const targetTool = ( | ||
| isRightButton || metaKeyPressed |
There was a problem hiding this comment.
@doouding
Here may should be "isRightButton && metaKeyPressed" if you meant rightbutton-dragging with ctrl or command (mac) pressed.
There was a problem hiding this comment.
Actuallly not, here I mean right button dragging OR meta key pressed.
There was a problem hiding this comment.
Actuallly not, here I mean right button dragging OR meta key pressed.
Oh I thought right button dragging could pan too. I take back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Press ctrl or command (mac) when dragging to activate AI.