Skip to content

fix: resolve remaining untranslated doc title case in detail page header#14820

Open
HanaB14 wants to merge 1 commit intotoeverything:canaryfrom
HanaB14:fix-14735-tab-title
Open

fix: resolve remaining untranslated doc title case in detail page header#14820
HanaB14 wants to merge 1 commit intotoeverything:canaryfrom
HanaB14:fix-14735-tab-title

Conversation

@HanaB14
Copy link
Copy Markdown
Contributor

@HanaB14 HanaB14 commented Apr 13, 2026

fix #14735

This PR fixes a remaining desktop case related to #14467.

The previous fix resolved incorrect translation in navigation panels, but the detail page header tab title was still passing custom document titles through i18n.t(), causing user-defined titles to be unexpectedly translated.

Results

Before.mov

After:
After

Summary by CodeRabbit

  • Refactor
    • Updated page title retrieval mechanism in workspace detail page headers. The title is now sourced directly from the document display metadata service instead of using the previous derivation method.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 13, 2026

📝 Walkthrough

Walkthrough

The page header title derivation in both JournalPageHeader and NormalPageHeader components is changed to retrieve the title directly from the document display metadata service instead of using i18n translation logic.

Changes

Cohort / File(s) Summary
Page Header Title Logic
packages/frontend/core/src/desktop/pages/workspace/detail-page/detail-page-header.tsx
Removed useI18n() dependency and i18n.t(...) call from title derivation; now uses useLiveData(docDisplayMetaService.title$(page.id)) directly.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The PR title accurately describes the main change: removing i18n translation from document titles in the detail page header, preventing user-defined titles from being incorrectly translated.
Linked Issues check ✅ Passed The code changes directly address the objective in linked issue #14735 by removing useI18n() usage and using docDisplayMetaService.title$ directly, ensuring custom document titles are not translated.
Out of Scope Changes check ✅ Passed All changes are focused on the detail page header title handling and directly related to fixing the untranslated title issue. No out-of-scope modifications detected.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@darkskygit darkskygit enabled auto-merge April 14, 2026 17:22
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.95%. Comparing base (a109f06) to head (3763d85).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #14820      +/-   ##
==========================================
- Coverage   57.32%   56.95%   -0.38%     
==========================================
  Files        3125     3125              
  Lines      169160   169160              
  Branches    25024    24900     -124     
==========================================
- Hits        96971    96338     -633     
- Misses      68936    69556     +620     
- Partials     3253     3266      +13     
Flag Coverage Δ
server-test 76.47% <ø> (-0.70%) ⬇️
unittest 34.25% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HanaB14
Copy link
Copy Markdown
Contributor Author

HanaB14 commented Apr 15, 2026

@darkskygit Thanks for the approval! The remaining failed checks seem to be flaky E2E/launch jobs. Could you help rerun them when convenient? Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect Translation via i18n

2 participants