fix: resolve remaining untranslated doc title case in detail page header#14820
fix: resolve remaining untranslated doc title case in detail page header#14820HanaB14 wants to merge 1 commit intotoeverything:canaryfrom
Conversation
📝 WalkthroughWalkthroughThe page header title derivation in both Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #14820 +/- ##
==========================================
- Coverage 57.32% 56.95% -0.38%
==========================================
Files 3125 3125
Lines 169160 169160
Branches 25024 24900 -124
==========================================
- Hits 96971 96338 -633
- Misses 68936 69556 +620
- Partials 3253 3266 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@darkskygit Thanks for the approval! The remaining failed checks seem to be flaky E2E/launch jobs. Could you help rerun them when convenient? Thanks :) |
fix #14735
This PR fixes a remaining desktop case related to #14467.
The previous fix resolved incorrect translation in navigation panels, but the detail page header tab title was still passing custom document titles through
i18n.t(), causing user-defined titles to be unexpectedly translated.Results
Before.mov
After:

Summary by CodeRabbit