fix: docTitle unexpectedly translated#14467
Conversation
📝 WalkthroughWalkthroughTwo navigation components (desktop and mobile) are updated to remove translation function calls on doc titles, using raw docTitle values instead. This change affects how document titles are displayed in the navigation panel. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Untitled // original title
if (originalTitle) return originalTitle;
// empty title
return this.i18nService.i18n.i18next.t('Untitled', { lng }); |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## canary #14467 +/- ##
==========================================
- Coverage 57.01% 56.92% -0.09%
==========================================
Files 2859 2859
Lines 154468 154468
Branches 23206 23199 -7
==========================================
- Hits 88073 87937 -136
- Misses 63488 63618 +130
- Partials 2907 2913 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fix toeverything#14465 In Chinese mode, the document with the specified name may not be displayed correctly in the sidebar, and it may be mistaken for the translation of the content that needs to be translated. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> * **Bug Fixes** * Fixed document title display in navigation panels on desktop and mobile to properly render without additional processing steps. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
fix #14465
In Chinese mode, the document with the specified name may not be displayed correctly in the sidebar, and it may be mistaken for the translation of the content that needs to be translated.
Summary by CodeRabbit