-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC Content revision joe #161
base: main
Are you sure you want to change the base?
Changes from all commits
ab9bf98
5923f6d
413dec8
1b84b3c
41f6b25
f7a9c55
7ed15cb
39862b0
8e35695
53aa2e1
1e3da90
386a42b
8973497
b14668a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,9 +7,9 @@ order: 2 | |
|
||
keyboard: | ||
skip-links: | | ||
Focus moves directly to the nav element | ||
Focus moves directly to the nav element or the first focusable control in the nav | ||
tab: | | ||
Focus moves to Links and buttons within the nav | ||
Focus moves to controls within the nav and there is a highly visible visual indication of keyboard focus | ||
|
||
mobile: | ||
swipe: | | ||
|
@@ -19,15 +19,15 @@ mobile: | |
|
||
screenreader: | ||
name: | | ||
It indicates its role AND IF multiple navigations are present (ex: Main navigation, Site map, Breadcrumbs), the name of the navigation | ||
it indicates its role AND IF multiple navigations are present (ex: Main navigation, Site map, Breadcrumbs), the name of the navigation | ||
role: | | ||
It is discoverable with screenreader shortcuts as a navigation landmark | ||
it is discoverable with screenreader shortcuts as a navigation landmark | ||
|
||
gherkin-keyboard: | ||
- when: | | ||
the arrow keys to browse the navigation menu | ||
tab is used to browse the navigation menu | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
result: | | ||
the screen scrolls through the page | ||
that there is a highly visible visual indication of keyboard focus on interactive controls within the navigation region | ||
|
||
gherkin-mobile: | ||
- when: | | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,17 +7,17 @@ categories: nav header | |
|
||
keyboard: | ||
tab: | | ||
Focus moves visibly to the search text input and search button | ||
Focus moves to the search text input and search button [if present] and there is a highly visible visual indication of keyboard focus | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I also find this all a bit confusing where we are saying focus is moving to both the search field AND the button. I feel like we should focus on the input behavior and make any mention of the button explicit and clear |
||
space: | | ||
Search button is activated | ||
Search button is activated [if present] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think lines 12 and 14 are flipped? should be about the search in line 12 and the search button for line 14? because space inside the search field would just add a space to the string being searched |
||
enter: | | ||
Search is activated | ||
Search is activated [if present] | ||
|
||
mobile: | ||
swipe: | | ||
Focus moves to the search text input and search button | ||
Focus moves to the search text input and search button [if present] | ||
doubletap: | | ||
Search button is activated | ||
Search button is activated [if present] | ||
|
||
screenreader: | ||
name: | | ||
|
@@ -31,9 +31,9 @@ gherkin-keyboard: | |
- when: | | ||
the tab key to move focus to a search input | ||
result: | | ||
focus is strongly visually indicated | ||
there is a highly visible visual indication of keyboard focus | ||
- then: | | ||
the tab key to move focus to the search submit button | ||
the tab key to move focus to the search submit button [if present] | ||
result: | | ||
the button is focused | ||
- then: | | ||
|
@@ -55,9 +55,8 @@ wcag: | |
- name: Operable | ||
list: | ||
- criteria: Is keyboard operable | ||
- criteria: Any click/tap target area is no smaller than 44x44px | ||
- criteria: Any click/tap target area is ideally no smaller than 44x44px | ||
- criteria: The disabled and focus states have a 3:1 minimum contrast ratio against default | ||
- criteria: The focus indication has a minimum area equal to the width of the element and 2px in height | ||
- criteria: A search submit button is also available and meets button design criteria | ||
- name: Understandable | ||
list: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍