AC Content revision joe #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritland
approved these changes
Oct 15, 2024
silverli
requested changes
Dec 24, 2024
|
|
||
| screenreader: | ||
| name: | | ||
| If multiple forms are present (Ex: Search, Sign in, Newsletter subscription), the form must have a name | ||
| role: | | ||
| It is discoverable with screenreader shortcuts as a form landmark along with its name | ||
| mode: | |
|
|
||
| gherkin-keyboard: | ||
| - when: | | ||
| the arrow keys to browse the navigation menu | ||
| tab is used to browse the navigation menu |
| space: | | ||
| Search button is activated | ||
| Search button is activated [if present] |
There was a problem hiding this comment.
I think lines 12 and 14 are flipped? should be about the search in line 12 and the search button for line 14? because space inside the search field would just add a space to the string being searched
| @@ -7,17 +7,17 @@ categories: nav header | |||
|
|
|||
| keyboard: | |||
| tab: | | |||
| Focus moves visibly to the search text input and search button | |||
| Focus moves to the search text input and search button [if present] and there is a highly visible visual indication of keyboard focus | |||
There was a problem hiding this comment.
I also find this all a bit confusing where we are saying focus is moving to both the search field AND the button. I feel like we should focus on the input behavior and make any mention of the button explicit and clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy edits to AC for the following Web components:
html
header
nav