gh-actions: fix ExCoveralls building #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@owenvoke, now it seems that everything works fine. The report has been done and returned successfully. I let you time to review it in the case you see something to improve in this PR, when your review will be done, we can merge it. |
owenvoke
approved these changes
May 14, 2020
Nor you nor even me take a look at that part hehe. Don't worry! I am going to merge it and perform the deletion of the Travis configuration because it seems everything works fine. |
ivanhercaz
added a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I specified on #16, it seems that Coveralls report isn't working and returning errors. I think it is because we did not consider to configure ExCoveralls for GitHub Actions as it is specified in its README.
This PR change set the
GITHUB_TOKENto{{ secrets.GITHUB_TOKEN }}and the script to report tomix coveralls.github.PS. I don't know the reason why my commits is unverified :/ I always sign them.