Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1593_removing_default_warning #1622

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

pushyamig
Copy link
Contributor

@pushyamig pushyamig commented Sep 11, 2024

Fixes #1593

There is an warning that is introduced due the way the package is imported.
MUI library import: https://v5-0-6.mui.com/system/screen-readers/
This was changed from package recommendation since the Codacy issue an alert and did not noted in the #1621

To see the issue here.
Go to Build Docker Image and then Search By AssignmentTable.js.

#18 25.41 WARNING in ./assets/src/components/AssignmentTable.js 367:12-26
#18 25.41 export 'default' (imported as 'visuallyHidden') was not found in '@mui/utils' (possible exports: HTMLElementType, chainPropTypes, deepmerge, elementAcceptingRef, elementTypeAcceptingRef, exactProp, formatMuiErrorMessage, getDisplayName, getValidReactChildren, integerPropType, internal_resolveProps, isPlainObject, ponyfillGlobal, refType, unstable_ClassNameGenerator, unstable_capitalize, unstable_composeClasses, unstable_createChainedFunction, unstable_debounce, unstable_deprecatedPropType, unstable_detectScrollType, unstable_generateUtilityClass, unstable_generateUtilityClasses, unstable_getNormalizedScrollLeft, unstable_getScrollbarSize, unstable_isMuiElement, unstable_ownerDocument, unstable_ownerWindow, unstable_requirePropFactory, unstable_setRef, unstable_unsupportedProp, unstable_useControlled, unstable_useEnhancedEffect, unstable_useEventCallback, unstable_useForkRef, unstable_useId, unstable_useIsFocusVisible, usePreviousProps, visuallyHidden)

This PR is built on my personal Github action and removed this issue
https://github.com/pushyamig/my-learning-analytics/actions/runs/10811068689/job/29989658800

@pushyamig pushyamig marked this pull request as ready for review September 11, 2024 11:51
@pushyamig
Copy link
Contributor Author

we need to ignore codacy warning in this case, We mostly observer Codacy warning but we rely VSCode Linting Standard for these

@pushyamig
Copy link
Contributor Author

@zqian I did not create an issue since this was introduced during the #1593 PR. I have enough details how to review this.

@pushyamig pushyamig changed the title #1593_removing_default_error #1593_removing_default_warning Sep 11, 2024
Copy link
Member

@zqian zqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is consistent with MUI documentation.

@pushyamig pushyamig merged commit 6698811 into tl-its-umich-edu:master Sep 11, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Communicate the number of returned results when using filters on the Assignment Planning view
2 participants