#1593 making the assignment changes screen readable #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pushyamig
commented
Sep 10, 2024
| @@ -15,7 +15,7 @@ root.render( | |||
| <Router basename='/'> | |||
| <ApolloProvider client={client}> | |||
| <ThemeProvider theme={siteTheme}> | |||
| <App user={user} gaId={gaId} cspNonce={cspNonce} oneTrustScriptDomain={oneTrustScriptDomain}/> | |||
| <App user={user} gaId={gaId} cspNonce={cspNonce} oneTrustScriptDomain={oneTrustScriptDomain} /> | |||
| </ThemeProvider> | |||
| </ApolloProvider> | |||
| </Router> | |||
There was a problem hiding this comment.
Changes here are due to linting error due to prior commits, which i am fixing it here
pushyamig
commented
Sep 10, 2024
| @@ -9,7 +9,7 @@ import useGoogleAnalytics from '@tl-its-umich-edu/react-ga-onetrust-consent' | |||
|
|
|||
| function App (props) { | |||
| const { user, gaId, cspNonce, oneTrustScriptDomain } = props | |||
| useGoogleAnalytics({ googleAnalyticsId: gaId, nonce: cspNonce, oneTrustScriptDomain}) | |||
There was a problem hiding this comment.
Changes here are due to linting error due to prior commits, which i am fixing it here
zqian
approved these changes
Sep 10, 2024
| @@ -368,6 +370,7 @@ function AssignmentTable (props) { | |||
| </Grid> | |||
| </Grid> | |||
| <TableContainer className={classes.container} ref={tableRef}> | |||
| <Box sx={visuallyHidden} aria-live='polite'>{filteredAssignments.length} assignments are listed</Box> | |||
There was a problem hiding this comment.
I have minor suggestion here for the singular vs plural statement, like:
0 assignment is listed
1 assignment is listed
2 assignments are listed
...
There was a problem hiding this comment.
I have implemented the change here c9842d3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1593
The issue request if based on the filter option it list the No. of assignments listed to screen readers. The info is not presented visually, but asked for adding it to screen reader
Testing
whenever any filter option changes or default filtering selected, it list the no. of assignment in the
Boxcomponent which is rendered asdivaria-live.mp4