fix(platform): add csi-operator sidecar and controller images #1424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@huxiaoliang Tke stack only support csi-operator images in local, csi images can be access from dockerhub, and the usage document has been added. |
TomatoAres
force-pushed
the
fix-1414-2
branch
2 times, most recently
from
e45b870 to
cc72f48
Compare
huxiaoliang
reviewed
Aug 4, 2021
hack/addon/readme/CSIOperator.md
Outdated
| | TencentCBS V1 |docker pull tkestack/csi-provisioner:v1.2.0 <br/>docker pull tkestack/csi-attacher:v1.1.0<br/>docker pull tkestack/csi-snapshotter:v1.2.2<br/>docker pull tkestack/csi-node-driver-registrar:v1.1.0<br/>docker pull tkestack/csi-tencentcloud-cbs:v1.0.0 <br />docker pull tkestack/csi-resizer:v0.5.0| | ||
| | TencentCBS V1P1 |docker pull tkestack/csi-provisioner:v1.2.0 <br/>docker pull tkestack/csi-attacher:v1.1.0<br/>docker pull tkestack/csi-snapshotter:v1.2.2<br/>docker pull tkestack/csi-node-driver-registrar:v1.1.0<br/>docker pull tkestack/csi-tencentcloud-cbs:v1.2.0 <br />docker pull tkestack/csi-resizer:v0.5.0| | ||
|
|
||
| 所有镜像均已上传 [公网 dockerhub](https://hub.docker.com/)，使用时 `csi-operator`根据配置的 存储类型拉取所需的镜像 |
huxiaoliang
reviewed
Aug 4, 2021
hack/addon/readme/CSIOperator.md
Outdated
| ### 镜像准备 | ||
|
|
||
| 当前支持的存储插件包括 RBD、CephFS、TencentCBS 和 TencentCFS（测试中，暂不支持）， | ||
| 针对不同的模式，依赖不同的 csi 镜像： |
Contributor
There was a problem hiding this comment.
please highlight here that the dependency image not in tkestack built-in registry but all in docker hub tkestack org, since it will cause the offline package too big, user have to download them manually if any
Contributor
Author
|
All images needed by csi-operator will be loaded by csi-operator from dockerhub, such as CBSv1:
|
huxiaoliang
requested changes
Aug 4, 2021
Contributor
huxiaoliang
left a comment
huxiaoliang
left a comment
There was a problem hiding this comment.
please address my comments, thanks
Contributor
Author
Modified as recommended |
Contributor
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
CSI-Operator need storage controller and sidecar images in local docker registry.
Which issue(s) this PR fixes:
Fixes #1414
Special notes for your reviewer:
# images needed in the feature cephfsplugin:v0.3.0 cephfsplugin:v1.0.0 csi-attacher:v0.4.2 csi-provisioner:v0.4.2 csi-resizer:v0.5.0 csi-snapshotter:v0.4.1 csi-tencentcloud-cbs:v0.2.1 csi-tencentcloud-cbs:v1.2.0 driver-registrar:v0.3.0 livenessprobe:v0.4.1 rbdplugin:v0.3.0 rbdplugin:v1.0.0NOTE: Stack now use a old version csi-operator image (ID sha256:b77952b83730), which only looks like v1.0.2.
Version of driver in this image is v1.0.0 but the version in csi-operator code is v1.2.0.
We decide to use the old version, and remember to bump csi-operator up to v1.0.3 to fix this issue.
Close the old fix(platform): add cbs sidecar and controller images #1419