fix(platform): add cbs sidecar and controller images #1419
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@TomatoAres please check why ci faild and re-tigger |
huxiaoliang
reviewed
Jul 20, 2021
TomatoAres
changed the title
huxiaoliang
requested changes
Jul 21, 2021
Contributor
huxiaoliang
left a comment
huxiaoliang
left a comment
There was a problem hiding this comment.
need to address my comments
Contributor
Author
The CI environment is broken, we are trying to fix it. |
Contributor
Author
|
Change method #1424 to fix bug, so close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
CSI-Operator need storage controller and sidecar images in local.
Which issue(s) this PR fixes:
Fixes #1414
Special notes for your reviewer:
Given in other storage images couldn't be accessible ,this PR only support TencentCBS V1.
# images added csi-tencentcloud-cbs:v1.0.0 csi-provisioner:v1.0.1 csi-attacher:v1.1.0 csi-snapshotter:v1.1.0 csi-node-driver-registrar:v1.1.0If tke stack need support all the storage system in the feature, we need all the dependent images.And the code modification is complete.
# images needed in the feature cephfsplugin:v0.3.0 cephfsplugin:v1.0.0 csi-attacher:v0.4.2 csi-provisioner:v0.4.2 csi-resizer:0.5.0 csi-snapshotter:v0.4.1 csi-tencentcloud-cbs:v0.2.1 csi-tencentcloud-cbs:v1.2.0 driver-registrar:v0.3.0 livenessprobe:v0.4.1 rbdplugin:v0.3.0 rbdplugin:v1.0.0Does this PR introduce a user-facing change?: