Misc optimizations that address some of the XXX comments
#202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titzer
reviewed
Oct 3, 2024
| // to Range<T> should be pretty much free. | ||
| component RangeUtil { | ||
| // Assumes that the vector is sorted. | ||
| def binarySearch<T>(range: Range<T>, val: T, lt: (T, T) -> bool) -> int { |
There was a problem hiding this comment.
I like this method. I think it should live in Virgil's lib/util and have some unittests.
| for (i < entries.length) { | ||
| var e = entries[i]; | ||
| if (e.0 == pc) match (e.1) { | ||
| var lower = RangeUtil.lowerbound(entries, (pc, null), cmp_lt_pc); |
There was a problem hiding this comment.
If you're looking for an exact match, I think it makes sense to have a utility method that specifically finds an exact match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves some of the
XXXtodos.