fix: move EmailTemplate seed to app startup to fix race condition (apn-0d1oa.13)#441
Closed
paulvanbrenk wants to merge 4 commits intomainfrom
Closed
fix: move EmailTemplate seed to app startup to fix race condition (apn-0d1oa.13)#441paulvanbrenk wants to merge 4 commits intomainfrom
paulvanbrenk wants to merge 4 commits intomainfrom
Conversation
…n-0d1oa.13) Two concurrent GETs could both see empty EmailTemplates table, both call SeedDefaultTemplatesAsync, and the second SaveChangesAsync would throw a unique constraint violation on the template Name column. Fix: seed at app startup using a scoped service before the app handles any requests. EnsureCreatedAsync is called first so startup works in test environments that use in-memory SQLite without migrations.
EnsureCreatedAsync at startup prevents the API from starting in CI environments where the database doesn't exist yet (e.g. OpenAPI spec export). The SeedDefaultTemplatesAsync method already handles the empty-table case safely without schema creation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 task
…rtup The startup seed block calls SeedDefaultTemplatesAsync which queries EmailTemplates. In SQLite environments (dev, test, OpenAPI export CI), the schema may not exist yet. Gate EnsureCreatedAsync on the SQLite provider so tests and CI can run without "no such table" errors, while production SQL Server (which uses migrations) is unaffected. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Closing — race condition is theoretical; production always has seeded templates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnsureCreatedAsynccall that caused API startup failure in CIIssue
Closes apn-0d1oa.13
What changed from PR #438
PR #438 included an
EnsureCreatedAsync()call that was not in the bug fix spec and caused the API to fail to start in the CI OpenAPI export step. This PR removes that call.Test plan
dotnet test PatchNotes.slnx)dotnet build)🤖 Generated with Claude Code