fix: move EmailTemplate seed to app startup to fix race condition (apn-0d1oa.13)#438
Closed
paulvanbrenk wants to merge 1 commit intomainfrom
Closed
fix: move EmailTemplate seed to app startup to fix race condition (apn-0d1oa.13)#438paulvanbrenk wants to merge 1 commit intomainfrom
paulvanbrenk wants to merge 1 commit intomainfrom
Conversation
…n-0d1oa.13) Two concurrent GETs could both see empty EmailTemplates table, both call SeedDefaultTemplatesAsync, and the second SaveChangesAsync would throw a unique constraint violation on the template Name column. Fix: seed at app startup using a scoped service before the app handles any requests. EnsureCreatedAsync is called first so startup works in test environments that use in-memory SQLite without migrations.
paulvanbrenk
force-pushed
the
merge/apn-0d1oa.13
branch
from
6945afb to
87369a9
Compare
2 tasks
Collaborator
Author
|
Closing in favor of #441 which fixes the EnsureCreatedAsync startup issue. |
auto-merge was automatically disabled
February 26, 2026 02:50
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue
Closes apn-0d1oa.13
Test plan
dotnet test PatchNotes.slnx)🤖 Merged by Refinery (ai_patch_notes merge queue processor)